Commit9db2ff1

committed

fix(win_mmap): unmark hidden win_errors due to smmap unicode foes

Now 2 more TCs pass in Windows:+ TestRepo.test_file_handle_leaks()+ TestObjDbPerformance.test_random_access()Seegitpython-developers/smmap#30

1 parent3910abf commit9db2ff1Copy full SHA for 9db2ff1

File tree

-9

lines changed

-9

lines changed

Lines changed: 0 additions & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -3,10 +3,6 @@`
`3`	`3`
`4`	`4`	`importsys`
`5`	`5`	`fromtimeimporttime`
`6`		`-fromunittest.caseimportskipIf`
`7`		`-`
`8`		`-fromgit.compatimportPY3`
`9`		`-fromgit.utilimportHIDE_WINDOWS_KNOWN_ERRORS`
`10`	`6`
`11`	`7`	`from .libimport (`
`12`	`8`	`TestBigRepoR`
`@@ -15,8 +11,6 @@`
`15`	`11`
`16`	`12`	`classTestObjDBPerformance(TestBigRepoR):`
`17`	`13`
`18`		`-@skipIf(HIDE_WINDOWS_KNOWN_ERRORSandPY3,`
`19`		`-"FIXME: smmp fails with: TypeError: Can't convert 'bytes' object to str implicitly")`
`20`	`14`	`deftest_random_access(self):`
`21`	`15`	`results= [["Iterate Commits"], ["Iterate Blobs"], ["Retrieve Blob Data"]]`
`22`	`16`	`forrepoin (self.gitrorepo,self.puregitrorepo):`

Lines changed: 0 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -808,8 +808,6 @@ def test_git_file(self, rwrepo):`
`808`	`808`	`git_file_repo=Repo(rwrepo.working_tree_dir)`
`809`	`809`	`self.assertEqual(osp.abspath(git_file_repo.git_dir),real_path_abs)`
`810`	`810`
`811`		`-@skipIf(HIDE_WINDOWS_KNOWN_ERRORSandPY3,`
`812`		`-"FIXME: smmp fails with: TypeError: Can't convert 'bytes' object to str implicitly")`
`813`	`811`	`deftest_file_handle_leaks(self):`
`814`	`812`	`deflast_commit(repo,rev,path):`
`815`	`813`	`commit=next(repo.iter_commits(rev,path,max_count=1))`

Lines changed: 0 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -9,7 +9,6 @@`
`9`	`9`	`fromgit.cmdimportGit`
`10`	`10`	`fromgit.compatimport (`
`11`	`11`	`string_types,`
`12`		`-is_win,`
`13`	`12`	`)`
`14`	`13`	`fromgit.excimport (`
`15`	`14`	`InvalidGitRepositoryError,`

Comments

(0)