Commit82b0a1e

committed

Clarify comments; add assertion (helps mypy)

1 parent24b065e commit82b0a1eCopy full SHA for 82b0a1e

File tree

-2

lines changed

-2

lines changed

Lines changed: 4 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -838,10 +838,11 @@ def version_info(self) -> Tuple[int, int, int, int]:`
`838`	`838`
`839`	`839`	`This value is generated on demand and is cached.`
`840`	`840`	`"""`
`841`		`-refresh_token=self._refresh_token# Copy it, in case of a concurrent refresh.`
	`841`	`+# Use a copy of this global state, in case of a concurrent refresh.`
	`842`	`+refresh_token=self._refresh_token`
`842`	`843`
`843`	`844`	`# Ask git for its version if we haven't done so since the last refresh.`
`844`		`-# (Refreshing is global, butversion information caching is per-instance.)`
	`845`	`+# (Refreshing is global, butversion_info caching is per-instance.)`
`845`	`846`	`ifself._version_info_tokenisnotrefresh_token:`
`846`	`847`	`# We only use the first 4 numbers, as everything else could be strings in fact (on Windows).`
`847`	`848`	`process_version=self._call_process("version")# Should be as default args and *kwargs used.`
`@@ -853,6 +854,7 @@ def version_info(self) -> Tuple[int, int, int, int]:`
`853`	`854`	`)`
`854`	`855`	`self._version_info_token=refresh_token`
`855`	`856`
	`857`	`+assertself._version_infoisnotNone,"Bug: token check should never let None through"`
`856`	`858`	`returnself._version_info`
`857`	`859`
`858`	`860`	`@overload`

Comments

(0)