Commit7f4a191

committed

Fix brittle way of checking warning messages

Which was causing a type error.

1 parentaee7078 commit7f4a191Copy full SHA for 7f4a191

File tree

-4

lines changed

-4

lines changed

Lines changed: 6 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -51,7 +51,7 @@ def test_util_alias_access_warns() -> None:`
`51`	`51`	`git.util`
`52`	`52`
`53`	`53`	`assertlen(ctx)==1`
`54`		`-message=ctx[0].message.args[0]`
	`54`	`+message=str(ctx[0].message)`
`55`	`55`	`assert"git.util"inmessage`
`56`	`56`	`assert"git.index.util"inmessage`
`57`	`57`	`assert"should not be relied on"inmessage`
`@@ -61,7 +61,7 @@ def test_util_alias_import_warns() -> None:`
`61`	`61`	`withpytest.deprecated_call()asctx:`
`62`	`62`	`fromgitimportutil# noqa: F401`
`63`	`63`
`64`		`-message=ctx[0].message.args[0]`
	`64`	`+message=str(ctx[0].message)`
`65`	`65`	`assert"git.util"inmessage`
`66`	`66`	`assert"git.index.util"inmessage`
`67`	`67`	`assert"should not be relied on"inmessage`
`@@ -114,10 +114,12 @@ def test_private_module_alias_access_warns(self, name: str, fullname: str) -> No`
`114`	`114`	`getattr(git,name)`
`115`	`115`
`116`	`116`	`assertlen(ctx)==1`
`117`		`-assertctx[0].message.args[0].endswith(f"Use{fullname} instead.")`
	`117`	`+message=str(ctx[0].message)`
	`118`	`+assertmessage.endswith(f"Use{fullname} instead.")`
`118`	`119`
`119`	`120`	`deftest_private_module_alias_import_warns(self,name:str,fullname:str)->None:`
`120`	`121`	`withpytest.deprecated_call()asctx:`
`121`	`122`	`exec(f"from git import{name}")`
`122`	`123`
`123`		`-assertctx[0].message.args[0].endswith(f"Use{fullname} instead.")`
	`124`	`+message=str(ctx[0].message)`
	`125`	`+assertmessage.endswith(f"Use{fullname} instead.")`

Comments

(0)