Commit7da9c3b

committed

Refactor "not from cwd" test for readability

By using pathlib.Path instead of os.path functions.

1 parent06bd2c7 commit7da9c3bCopy full SHA for 7da9c3b

File tree

-5

lines changed

-5

lines changed

Lines changed: 5 additions & 5 deletions

Original file line number	Diff line number	Diff line change
`@@ -9,6 +9,7 @@`
`9`	`9`	`importlogging`
`10`	`10`	`importos`
`11`	`11`	`importos.pathasosp`
	`12`	`+frompathlibimportPath`
`12`	`13`	`importre`
`13`	`14`	`importshutil`
`14`	`15`	`importsubprocess`
`@@ -150,14 +151,13 @@ def test_it_executes_git_not_from_cwd(self, rw_dir, case):`
`150`	`151`	`ifos.name=="nt":`
`151`	`152`	`# Copy an actual binary executable that is not git. (On Windows, running`
`152`	`153`	`# "hostname" only displays the hostname, it never tries to change it.)`
`153`		`-other_exe_path=os.path.join(os.environ["SystemRoot"],"system32","hostname.exe")`
`154`		`-impostor_path=os.path.join(rw_dir,"git.exe")`
	`154`	`+other_exe_path=Path(os.environ["SystemRoot"],"system32","hostname.exe")`
	`155`	`+impostor_path=Path(rw_dir,"git.exe")`
`155`	`156`	`shutil.copy(other_exe_path,impostor_path)`
`156`	`157`	`else:`
`157`	`158`	`# Create a shell script that doesn't do anything.`
`158`		`-impostor_path=os.path.join(rw_dir,"git")`
`159`		`-withopen(impostor_path,mode="w",encoding="utf-8")asfile:`
`160`		`-print("#!/bin/sh",file=file)`
	`159`	`+impostor_path=Path(rw_dir,"git")`
	`160`	`+impostor_path.write_text("#!/bin/sh\n",encoding="utf-8")`
`161`	`161`	`os.chmod(impostor_path,0o755)`
`162`	`162`
`163`	`163`	`withcwd(rw_dir)ifchdir_to_repoelsecontextlib.nullcontext():`

Comments

(0)