Commit78a82b3

committed

Don't access logger in tests by nonpublic attribute

This changes a couple tests that access specific loggers to use thelogger name instead, as code outside GitPython should do.

1 parent7bbccb4 commit78a82b3Copy full SHA for 78a82b3

File tree

-2

lines changed

-2

lines changed

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -133,7 +133,7 @@ def test_it_uses_shell_or_not_as_specified(self, case):`
`133`	`133`	`deftest_it_logs_if_it_uses_a_shell(self,case):`
`134`	`134`	"""``shell=`` in the log message agrees with what is passed to `Popen`."""
`135`	`135`	`value_in_call,value_from_class=case`
`136`		`-withself.assertLogs(cmd._logger,level=logging.DEBUG)aslog_watcher:`
	`136`	`+withself.assertLogs(cmd.__name__,level=logging.DEBUG)aslog_watcher:`
`137`	`137`	`mock_safer_popen=self._do_shell_combo(value_in_call,value_from_class)`
`138`	`138`	`self._assert_logged_for_popen(log_watcher,"shell",mock_safer_popen.call_args.kwargs["shell"])`
`139`	`139`
`@@ -143,7 +143,7 @@ def test_it_logs_if_it_uses_a_shell(self, case):`
`143`	`143`	`)`
`144`	`144`	`deftest_it_logs_istream_summary_for_stdin(self,case):`
`145`	`145`	`expected_summary,istream_argument=case`
`146`		`-withself.assertLogs(cmd._logger,level=logging.DEBUG)aslog_watcher:`
	`146`	`+withself.assertLogs(cmd.__name__,level=logging.DEBUG)aslog_watcher:`
`147`	`147`	`self.git.execute(["git","version"],istream=istream_argument)`
`148`	`148`	`self._assert_logged_for_popen(log_watcher,"stdin",expected_summary)`
`149`	`149`

Comments

(0)