Commit4ba76d6

Xavier Verges

authored and

committed

Do not break convention when updating sys.path

1 parent7cd47ae commit4ba76d6Copy full SHA for 4ba76d6

File tree

-1

lines changed

-1

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -19,7 +19,7 @@`
`19`	`19`	`def_init_externals():`
`20`	`20`	`"""Initialize external projects by putting them into the path"""`
`21`	`21`	`if__version__=='git'and'PYOXIDIZER'notinos.environ:`
`22`		`-sys.path.insert(0,osp.join(osp.dirname(__file__),'ext','gitdb'))`
	`22`	`+sys.path.insert(1,osp.join(osp.dirname(__file__),'ext','gitdb'))`
`23`	`23`
`24`	`24`	`try:`
`25`	`25`	`importgitdb`

Lines changed: 6 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,7 @@`
`1`	`1`	`# This module is part of GitPython and is released under`
`2`	`2`	`# the BSD License: http://www.opensource.org/licenses/bsd-license.php`
`3`	`3`
	`4`	`+importast`
`4`	`5`	`importos`
`5`	`6`	`importsubprocess`
`6`	`7`	`fromtest.libimportTestBase`
`@@ -27,3 +28,8 @@ def test_installation(self, rw_dir):`
`27`	`28`	`self.assertEqual(0,result.returncode,msg=result.stderrorresult.stdoutor"Can't build - setup.py failed")`
`28`	`29`	`result=subprocess.run([self.python,'-c','import git'],stdout=subprocess.PIPE,cwd=self.sources)`
`29`	`30`	`self.assertEqual(0,result.returncode,msg=result.stderrorresult.stdoutor"Selftest failed")`
	`31`	`+result=subprocess.run([self.python,'-c','import sys;import git; print(sys.path)'],stdout=subprocess.PIPE,cwd=self.sources)`
	`32`	`+syspath=result.stdout.decode('utf-8').splitlines()[0]`
	`33`	`+syspath=ast.literal_eval(syspath)`
	`34`	`+self.assertEqual('',syspath[0],msg='Failed to follow the conventions for https://docs.python.org/3/library/sys.html#sys.path')`
	`35`	`+self.assertTrue(syspath[1].endswith('gitdb'),msg='Failed to add gitdb to sys.path')`

Comments

(0)