Commit3dbf5b3

authored

Merge pull request#1753 from EliahKagan/fds

Let close_fds be True on all platforms

2 parents7c423b4 +78d63d9 commit3dbf5b3Copy full SHA for 3dbf5b3

File tree

-2

lines changed

-2

lines changed

Lines changed: 0 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1001,7 +1001,6 @@ def execute(`
`1001`	`1001`	`stderr=PIPE,`
`1002`	`1002`	`stdout=stdout_sink,`
`1003`	`1003`	`shell=shell,`
`1004`		`-close_fds=(os.name=="posix"),# Unsupported on Windows.`
`1005`	`1004`	`universal_newlines=universal_newlines,`
`1006`	`1005`	`creationflags=PROC_CREATIONFLAGS,`
`1007`	`1006`	`**subprocess_kwargs,`

Lines changed: 0 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -102,7 +102,6 @@ def run_commit_hook(name: str, index: "IndexFile", *args: str) -> None:`
`102`	`102`	`stdout=subprocess.PIPE,`
`103`	`103`	`stderr=subprocess.PIPE,`
`104`	`104`	`cwd=index.repo.working_dir,`
`105`		`-close_fds=(os.name=="posix"),`
`106`	`105`	`creationflags=PROC_CREATIONFLAGS,`
`107`	`106`	`)`
`108`	`107`	`exceptExceptionasex:`

Comments

(0)