Commit2e0d835

authored

Merge pull request#2045 from EliahKagan/shell-warning-refactor

Clarify `USE_SHELL` warning helper signature

2 parentsb6a188b +253099f commit2e0d835Copy full SHA for 2e0d835

File tree

-4

lines changed

-4

lines changed

Lines changed: 4 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -550,7 +550,7 @@ def __del__(self) -> None:`
`550`	`550`	`)`
`551`	`551`
`552`	`552`
`553`		`-def_warn_use_shell(extra_danger:bool)->None:`
	`553`	`+def_warn_use_shell(*,extra_danger:bool)->None:`
`554`	`554`	`warnings.warn(`
`555`	`555`	`_USE_SHELL_DANGER_MESSAGEifextra_dangerelse_USE_SHELL_DEFAULT_MESSAGE,`
`556`	`556`	`DeprecationWarning,`
`@@ -566,12 +566,12 @@ class _GitMeta(type):`
`566`	`566`
`567`	`567`	`def__getattribute(cls,name:str)->Any:`
`568`	`568`	`ifname=="USE_SHELL":`
`569`		`-_warn_use_shell(False)`
	`569`	`+_warn_use_shell(extra_danger=False)`
`570`	`570`	`returnsuper().__getattribute__(name)`
`571`	`571`
`572`	`572`	`def__setattr(cls,name:str,value:Any)->Any:`
`573`	`573`	`ifname=="USE_SHELL":`
`574`		`-_warn_use_shell(value)`
	`574`	`+_warn_use_shell(extra_danger=value)`
`575`	`575`	`super().__setattr__(name,value)`
`576`	`576`
`577`	`577`	`ifnotTYPE_CHECKING:`
`@@ -988,7 +988,7 @@ def __init__(self, working_dir: Union[None, PathLike] = None) -> None:`
`988`	`988`
`989`	`989`	`def__getattribute__(self,name:str)->Any:`
`990`	`990`	`ifname=="USE_SHELL":`
`991`		`-_warn_use_shell(False)`
	`991`	`+_warn_use_shell(extra_danger=False)`
`992`	`992`	`returnsuper().__getattribute__(name)`
`993`	`993`
`994`	`994`	`def__getattr__(self,name:str)->Any:`

Comments

(0)