Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit2b85cd1

Browse files
committed
Fix ambiguous_safer_popen_windows comment
This fixes some ambiguous wording in a comment in`_safer_popen_wording`, where it was unclear if the secondaryproblem -- where it would be possible to run a wrong `cmd.exe`-typeshell -- would happen under two separate circumstances, or onlywhen both circumstances occurred together. This adjusts its wordingto make clear that it is the latter.This also fixes a minor typo in another `_safer_popen_windows`comment.This might be viewed as building on the improvements inb9d9e56(#1859), but the changes here are to comments only.
1 parent82aaa13 commit2b85cd1

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

‎git/cmd.py‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -273,12 +273,12 @@ def _safer_popen_windows(
273273
ifshell:
274274
# The original may be immutable, or the caller may reuse it. Mutate a copy.
275275
env= {}ifenvisNoneelsedict(env)
276-
env["NoDefaultCurrentDirectoryInExePath"]="1"# The "1" can bean value.
276+
env["NoDefaultCurrentDirectoryInExePath"]="1"# The "1" can beany value.
277277

278278
# When not using a shell, the current process does the search in a
279279
# CreateProcessW API call, so the variable must be set in our environment. With
280280
# a shell, that's unnecessary if https://github.com/python/cpython/issues/101283
281-
# is patched. In Python versions where it is unpatched,andin the rare case the
281+
# is patched. In Python versions where it is unpatched, in the rare case the
282282
# ComSpec environment variable is unset, the search for the shell itself is
283283
# unsafe. Setting NoDefaultCurrentDirectoryInExePath in all cases, as done here,
284284
# is simpler and protects against that. (As above, the "1" can be any value.)

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp