Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Commit2ae697d

Browse files
committed
Marktest_installation xfail on Cygwin CI
Together with#2007, this works around#2004, allowing all tests topass on Cygwin CI.In#2007, installation of the environment in which tests run wasfixed by downloading and running the `get-pip.py` bootstrap script.If we were to modify our helper that sets up the (separate) virtualenvironment in `test_installation` so that it does the same thing(or conditionally does so on CI, since the problem does not seem tohappen in local installations), that would likely "fix" this morethoroughly, allowing the test to pass.But part of the goal of the installation test is to test thatinstallation works in a typical environment on the platform it runson. So it is not obivous that making it pass in that way would bean improvement compared to marking it `xfail` with the exceptiontype that occurs due to#2004. So this just does that, for now.
1 parentfe7533e commit2ae697d

File tree

1 file changed

+8
-0
lines changed

1 file changed

+8
-0
lines changed

‎test/test_installation.py

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,11 +4,19 @@
44
importast
55
importos
66
importsubprocess
7+
importsys
8+
9+
importpytest
710

811
fromtest.libimportTestBase,VirtualEnvironment,with_rw_directory
912

1013

1114
classTestInstallation(TestBase):
15+
@pytest.mark.xfail(
16+
sys.platform=="cygwin"and"CI"inos.environ,
17+
reason="Trouble with pip on Cygwin CI, see issue #2004",
18+
raises=subprocess.CalledProcessError,
19+
)
1220
@with_rw_directory
1321
deftest_installation(self,rw_dir):
1422
venv=self._set_up_venv(rw_dir)

0 commit comments

Comments
 (0)

[8]ページ先頭

©2009-2025 Movatter.jp