Commit226f4ff

committed

check that uname_cmd points to a file; if uname_cmd were a directory, it could both exist and have os.X_OK but not work

1 parent3f5a942 commit226f4ffCopy full SHA for 226f4ff

File tree

-1

lines changed

-1

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -465,7 +465,7 @@ def _is_cygwin_git(git_executable: str) -> bool:`
`465`	`465`	`# Just a name given, not a real path.`
`466`	`466`	`uname_cmd=osp.join(git_dir,"uname")`
`467`	`467`
`468`		`-ifnot (pathlib.Path(uname_cmd).exists()andos.access(uname_cmd,os.X_OK)):`
	`468`	`+ifnot (pathlib.Path(uname_cmd).isfile()andos.access(uname_cmd,os.X_OK)):`
`469`	`469`	`_logger.debug(f"Failed checking if running in CYGWIN:{uname_cmd} is not an executable")`
`470`	`470`	`_is_cygwin_cache[git_executable]=is_cygwin`
`471`	`471`	`returnis_cygwin`

Comments

(0)