Commit12db6bb

authored

fix(cmd): checking process.DEVNUL were needlessly openingos.devnull

Fixes resource-leak warning on Windows Puython-3.5.3+:D:\python-3.5.2.amd64\lib\site-packages\git\cmd.py:583: ResourceWarning:unclosed file <_io.BufferedWriter name='nul'> else getattr(subprocess, 'DEVNULL', open(os.devnull, 'wb')))

1 parentb197de0 commit12db6bbCopy full SHA for 12db6bb

File tree

1 file changed

-1

lines changed

git
- cmd.py

1 file changed

-1

lines changed

`‎git/cmd.py`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -580,7 +580,7 @@ def execute(self, command,`
`580`	`580`
`581`	`581`	`stdout_sink= (PIPE`
`582`	`582`	`ifwith_stdout`
`583`		`-elsegetattr(subprocess,'DEVNULL',open(os.devnull,'wb')))`
	`583`	`+elsegetattr(subprocess,'DEVNULL',None)oropen(os.devnull,'wb'))`
`584`	`584`	`log.debug("Popen(%s, cwd=%s, universal_newlines=%s, shell=%s)",`
`585`	`585`	`command,cwd,universal_newlines,shell)`
`586`	`586`	`try:`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Commit12db6bb

File tree

1 file changed

1 file changed

`‎git/cmd.py`

0 commit comments