Commitf7b7eb6

committed

Added Remote.exists() method, and test.Fixesgitpython-developers#229

1 parentc7887c6 commitf7b7eb6Copy full SHA for f7b7eb6

File tree

+23

-2

lines changed

+23

-2

lines changed

Lines changed: 13 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -397,6 +397,19 @@ def __ne__(self, other):`
`397`	`397`	`def__hash__(self):`
`398`	`398`	`returnhash(self.name)`
`399`	`399`
	`400`	`+defexists(self):`
	`401`	`+""":return: True if this is a valid, existing remote.`
	`402`	`+ Valid remotes have an entry in the repository's configuration"""`
	`403`	`+try:`
	`404`	`+self.config_reader.get('url')`
	`405`	`+returnTrue`
	`406`	`+exceptcp.NoOptionError:`
	`407`	`+# we have the section at least ...`
	`408`	`+returnTrue`
	`409`	`+exceptcp.NoSectionError:`
	`410`	`+returnFalse`
	`411`	`+# end`
	`412`	`+`
`400`	`413`	`@classmethod`
`401`	`414`	`defiter_items(cls,repo):`
`402`	`415`	`""":return: Iterator yielding Remote objects of the given repository"""`

Lines changed: 4 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -250,7 +250,10 @@ def remotes(self):`
`250`	`250`	`defremote(self,name='origin'):`
`251`	`251`	`""":return: Remote with the specified name`
`252`	`252`	`:raise ValueError: if no remote with such a name exists"""`
`253`		`-returnRemote(self,name)`
	`253`	`+r=Remote(self,name)`
	`254`	`+ifnotr.exists():`
	`255`	`+raiseValueError("Remote named '%s' didn't exist"%name)`
	`256`	`+returnr`
`254`	`257`
`255`	`258`	`#{ Submodules`
`256`	`259`

Lines changed: 6 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,8 @@`
`25`	`25`	`Reference,`
`26`	`26`	`GitDB,`
`27`	`27`	`Submodule,`
`28`		`-GitCmdObjectDB`
	`28`	`+GitCmdObjectDB,`
	`29`	`+Remote`
`29`	`30`	`)`
`30`	`31`	`fromgit.utilimportjoin_path_native`
`31`	`32`	`fromgit.excimportBadObject`
`@@ -673,3 +674,7 @@ def last_commit(repo, rev, path):`
`673`	`674`	`last_commit(repo,'master','git/test/test_base.py')`
`674`	`675`	`# end for each repository type`
`675`	`676`	`# end for each iteration`
	`677`	`+`
	`678`	`+deftest_remote_method(self):`
	`679`	`+self.failUnlessRaises(ValueError,self.rorepo.remote,'foo-blue')`
	`680`	`+assertisinstance(self.rorepo.remote(name='origin'),Remote)`

Comments

(0)