Commitbcd57e3

committed

Corrected a problem with commits_between returning None.

This was caused by calling reverse on the list, which reverses the list inplace and returns None. We really need tests for this.

1 parent0ca61d4 commitbcd57e3Copy full SHA for bcd57e3

File tree

-2

lines changed

-2

lines changed

Lines changed: 7 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -40,6 +40,13 @@ Head`
`40`	`40`	`* Corrected problem where branches was only returning the last path component`
`41`	`41`	`instead of the entire path component following refs/heads/.`
`42`	`42`
	`43`	`+Repo`
	`44`	`+----`
	`45`	`+* Modified the gzip archive creation to use the python gzip module.`
	`46`	`+`
	`47`	+* Corrected ``commits_between`` always returning None instead of the reversed
	`48`	`+ list.`
	`49`	`+`
`43`	`50`
`44`	`51`	`0.1.5`
`45`	`52`	`=====`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -138,12 +138,12 @@ def commits_between(self, frm, to, path = ''):`
`138`	`138`	`is the branch/commit name of the older item`
`139`	`139`
`140`	`140`	``path``
`141`		`- is anoptinal path`
	`141`	`+ is anoptional path`
`142`	`142`
`143`	`143`	`Returns`
`144`	`144`	``git.Commit[]``
`145`	`145`	`"""`
`146`		`-returnCommit.find_all(self,"%s..%s"% (frm,to),path).reverse()`
	`146`	`+returnreversed(Commit.find_all(self,"%s..%s"% (frm,to)))`
`147`	`147`
`148`	`148`	`defcommits_since(self,start='master',path='',since='1970-01-01'):`
`149`	`149`	`"""`

Comments

(0)