Commit5ac93b1

committed

Use uuid instead of tempfile.mkdtmp, which created an actual directory.

That, over time, could have caused slow downs due to file-system hassle.Fixesgitpython-developers#258

1 parentf51fe3e commit5ac93b1Copy full SHA for 5ac93b1

File tree

-2

lines changed

-2

lines changed

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -37,7 +37,7 @@`
`37`	`37`
`38`	`38`	`importos`
`39`	`39`	`importlogging`
`40`		`-importtempfile`
	`40`	`+importuuid`
`41`	`41`
`42`	`42`	`__all__= ["Submodule","UpdateProgress"]`
`43`	`43`
`@@ -992,7 +992,7 @@ def rename(self, new_name):`
`992`	`992`	`source_dir=mod.git_dir`
`993`	`993`	`# Let's be sure the submodule name is not so obviously tied to a directory`
`994`	`994`	`ifdestination_module_abspath.startswith(mod.git_dir):`
`995`		`-tmp_dir=self._module_abspath(self.repo,self.path,os.path.basename(tempfile.mkdtemp()))`
	`995`	`+tmp_dir=self._module_abspath(self.repo,self.path,str(uuid.uuid4()))`
`996`	`996`	`os.renames(source_dir,tmp_dir)`
`997`	`997`	`source_dir=tmp_dir`
`998`	`998`	`# end handle self-containment`

Comments

(0)