Commit33401c3

committed

Fixed git.blob.Blob.blame function which would return the text-per-commit as individual characters

1 parent4c39f9d commit33401c3Copy full SHA for 33401c3

File tree

-1

lines changed

-1

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -135,7 +135,7 @@ def blame(cls, repo, commit, file):`
`135`	`135`	`m=re.search(r'^\t(.*)$',line)`
`136`	`136`	`text,=m.groups()`
`137`	`137`	`blames[-1][0]=c`
`138`		`-blames[-1][1]+=text`
	`138`	`+blames[-1][1].append(text )`
`139`	`139`	`info=None`
`140`	`140`
`141`	`141`	`returnblames`

Lines changed: 8 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -69,6 +69,7 @@ def test_should_display_blame_information(self, git):`
`69`	`69`	`git.return_value=fixture('blame')`
`70`	`70`	`b=Blob.blame(self.repo,'master','lib/git.py')`
`71`	`71`	`assert_equal(13,len(b))`
	`72`	`+assert_equal(2,len(b[0]) )`
`72`	`73`	`# assert_equal(25, reduce(lambda acc, x: acc + len(x[-1]), b))`
`73`	`74`	`assert_equal(hash(b[0][0]),hash(b[9][0]))`
`74`	`75`	`c=b[0][0]`
`@@ -83,6 +84,13 @@ def test_should_display_blame_information(self, git):`
`83`	`84`	`assert_equal('tom@mojombo.com',c.committer.email)`
`84`	`85`	`assert_equal(time.gmtime(1191997100),c.committed_date)`
`85`	`86`	`assert_equal('initial grit setup',c.message)`
	`87`	`+`
	`88`	`+# test the 'lines per commit' entries`
	`89`	`+tlist=b[0][1]`
	`90`	`+assert_true(tlist )`
	`91`	`+assert_true(isinstance(tlist[0],basestring ) )`
	`92`	`+assert_true(len(tlist )<sum(len(t)fortintlist ) )# test for single-char bug`
	`93`	`+`
`86`	`94`
`87`	`95`	`deftest_should_return_appropriate_representation(self):`
`88`	`96`	`blob=Blob(self.repo,**{'id':'abc'})`

Comments

(0)