Commitc65e74e

committed

Try to stop creating Authorizations recklessly.

1 parenta09d472 commitc65e74eCopy full SHA for c65e74e

File tree

-18

lines changed

-18

lines changed

Lines changed: 4 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -67,22 +67,22 @@ def update(self, scopes=[], add_scopes=[], rm_scopes=[], note='',`
`67`	`67`	`success=False`
`68`	`68`	`ifscopes:`
`69`	`69`	`d=dumps({'scopes':scopes})`
`70`		`-json=self._json(self._get(self._api,data=d),200)`
	`70`	`+json=self._json(self._post(self._api,data=d),200)`
`71`	`71`	`self._update_(json)`
`72`	`72`	`success=True`
`73`	`73`	`ifadd_scopes:`
`74`	`74`	`d=dumps({'add_scopes':add_scopes})`
`75`		`-json=self._json(self._get(self._api,data=d),200)`
	`75`	`+json=self._json(self._post(self._api,data=d),200)`
`76`	`76`	`self._update_(json)`
`77`	`77`	`success=True`
`78`	`78`	`ifrm_scopes:`
`79`	`79`	`d=dumps({'remove_scopes':rm_scopes})`
`80`		`-json=self._json(self._get(self._api,data=d),200)`
	`80`	`+json=self._json(self._post(self._api,data=d),200)`
`81`	`81`	`self._update_(json)`
`82`	`82`	`success=True`
`83`	`83`	`ifnoteornote_url:`
`84`	`84`	`d=dumps({'note':note,'note_url':note_url})`
`85`		`-json=self._json(self._get(self._api,data=d),200)`
	`85`	`+json=self._json(self._post(self._api,data=d),200)`
`86`	`86`	`self._update_(json)`
`87`	`87`	`success=True`
`88`	`88`	`returnsuccess`

Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -54,15 +54,19 @@ def test_scopes(self):`
`54`	`54`	`deftest_update(self):`
`55`	`55`	`ifnotself.auth:`
`56`	`56`	`return`
	`57`	`+`
`57`	`58`	`ifself.deleted:`
`58`	`59`	`self.authorization=self._g.authorize(None,None, [])`
	`60`	`+`
`59`	`61`	`self.authorization.update(['repo','repo:status'], ['user'],`
`60`	`62`	`['repo:status'],'https://github.com/sigmavirus24/github3.py')`
	`63`	`+`
`61`	`64`	`ifself.deleted:`
`62`	`65`	`self.authorization.delete()`
`63`	`66`
`64`	`67`	`deftest_delete(self):`
`65`	`68`	`ifnotself.auth:`
`66`	`69`	`return`
	`70`	`+`
`67`	`71`	`self.authorization.delete()`
`68`	`72`	`self.deleted=True`

Lines changed: 0 additions & 14 deletions

Original file line number	Diff line number	Diff line change
`@@ -291,20 +291,6 @@ def test_user(self):`
`291`	`291`
`292`	`292`	`expect(self._g.user()).isinstance(github3.users.User)`
`293`	`293`
`294`		`-deftest_authorization(self):`
`295`		`-ifnotself.auth:`
`296`		`-return`
`297`		`-`
`298`		`-auth=self.g.authorize(self.user,self.pw, [])`
`299`		`-expect(auth).isinstance(github3.github.Authorization)`
`300`		`-auth_g=self._g.authorization(auth.id)`
`301`		`-expect(auth_g).isinstance(github3.github.Authorization)`
`302`		`-auth.delete()`
`303`		`-delauth`
`304`		`-auth=self._g.authorize(None,None, [])`
`305`		`-expect(auth).isinstance(github3.github.Authorization)`
`306`		`-auth.delete()`
`307`		`-`
`308`	`294`	`deftest_subscribe_unsub(self):`
`309`	`295`	`args= (self.gh3py,self.test_repo)`
`310`	`296`	`self.raisesGHE(self.g.subscribe,*args)`

Comments

(0)