Commit8713f07

committed

Last iteration forsigmavirus24#128 and unit test for it

1 parent27750e1 commit8713f07Copy full SHA for 8713f07

File tree

+30

-2

lines changed

+30

-2

lines changed

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,7 @@ def __init__(self, count, url, cls, session, params=None, etag=None):`
`16`	`16`	`#: Class being used to cast all items to`
`17`	`17`	`self.cls=cls`
`18`	`18`	`#: Parameters of the query string`
`19`		`-self.params=params`
	`19`	`+self.params=paramsor {}`
`20`	`20`	`self._remove_none(self.params)`
`21`	`21`	`# We do not set this from the parameter sent. We want this to`
`22`	`22`	`# represent the ETag header returned by GitHub no matter what.`
`@@ -42,7 +42,7 @@ def __iter__(self):`
`42`	`42`	`url,params,cls=self.url,self.params,self.cls`
`43`	`43`	`headers=self.headers`
`44`	`44`
`45`		`-ifparamsand'per_page'notinparams:`
	`45`	`+if'per_page'notinparams:`
`46`	`46`	`params['per_page']=100`
`47`	`47`
`48`	`48`	`while (self.count==-1orself.count>0)andurl:`

Lines changed: 28 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,28 @@`
	`1`	`+from .helperimportUnitHelper`
	`2`	`+fromgithub3.structsimportGitHubIterator`
	`3`	`+`
	`4`	`+importmock`
	`5`	`+`
	`6`	`+`
	`7`	`+classTestGitHubIterator(UnitHelper):`
	`8`	`+described_class=GitHubIterator`
	`9`	`+`
	`10`	`+defcreate_instance_of_described_class(self):`
	`11`	`+self.url='https://api.github.com/users'`
	`12`	`+klass=lambda*args:args`
	`13`	`+instance=self.described_class(count=-1,url=self.url,cls=klass,`
	`14`	`+session=self.session)`
	`15`	`+returninstance`
	`16`	`+`
	`17`	`+deftest_sets_per_page_to_100(self):`
	`18`	`+"""Test that the Iterator defaults the per_page parameter to 100"""`
	`19`	`+self.session.get.return_value=mock.Mock(status_code=200,`
	`20`	`+json=lambda: [],`
	`21`	`+links={})`
	`22`	`+`
	`23`	`+foriinself.instance:`
	`24`	`+break`
	`25`	`+`
	`26`	`+self.session.get.assert_called_once_with(`
	`27`	`+self.url,params={'per_page':100},headers={}`
	`28`	`+ )`

Comments

(0)