Commit71a4eef

committed

Merge pull requestsigmavirus24#247 from davidmoss/develop

Adding support for calling URL with invalid SSL cert

2 parents2ebe446 +630fbe5 commit71a4eefCopy full SHA for 71a4eef

File tree

+21

-1

lines changed

+21

-1

lines changed

Lines changed: 2 additions & 0 deletions

Lines changed: 5 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1459,10 +1459,14 @@ class GitHubEnterprise(GitHub):`
`1459`	`1459`
`1460`	`1460`	`There is no need to provide the end of the url (e.g., /api/v3/), that will`
`1461`	`1461`	`be taken care of by us.`
	`1462`	`+`
	`1463`	`+ If you have a self signed SSL for your local github enterprise you can`
	`1464`	+ override the validation by passing `verify=False`.
`1462`	`1465`	`"""`
`1463`		`-def__init__(self,url,login='',password='',token=''):`
	`1466`	`+def__init__(self,url,login='',password='',token='',verify=True):`
`1464`	`1467`	`super(GitHubEnterprise,self).__init__(login,password,token)`
`1465`	`1468`	`self._session.base_url=url.rstrip('/')+'/api/v3'`
	`1469`	`+self._session.verify=verify`
`1466`	`1470`
`1467`	`1471`	`def_repr(self):`
`1468`	`1472`	`return'<GitHub Enterprise [0.url]>'.format(self)`

Lines changed: 14 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,5 @@`
`1`	`1`	`importgithub3`
	`2`	`+`
`2`	`3`	`fromtests.utilsimport (BaseCase,load,mock)`
`3`	`4`
`4`	`5`
`@@ -852,6 +853,19 @@ def test_pubsubhubbub(self):`
`852`	`853`	`self.mock_assertions()`
`853`	`854`
`854`	`855`
	`856`	`+classTestUnsecureGitHubEnterprise(BaseCase):`
	`857`	`+defsetUp(self):`
	`858`	`+super(TestUnsecureGitHubEnterprise,self).setUp()`
	`859`	`+self.g=github3.GitHubEnterprise('https://github.example.com:8080/',verify=False)`
	`860`	`+`
	`861`	`+deftest_skip_ssl_validation(self):`
	`862`	`+self.response('pull_enterprise')`
	`863`	`+self.g.pull_request('sigmavirus24','github3.py',19)`
	`864`	`+`
	`865`	`+assertFalse==self.g._session.verify`
	`866`	`+assertself.request.called`
	`867`	`+`
	`868`	`+`
`855`	`869`	`classTestGitHubStatus(BaseCase):`
`856`	`870`	`defsetUp(self):`
`857`	`871`	`super(TestGitHubStatus,self).setUp()`

Comments

(0)