Commit6e37d74

committed

Fix potential bug in Hook.edit

Add more rigorous tests for Hook.edit.

1 parent5a36bb0 commit6e37d74Copy full SHA for 6e37d74

File tree

-3

lines changed

-3

lines changed

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1830,7 +1830,7 @@ def edit(self, name, config, events=[], add_events=[], rm_events=[],`
`1830`	`1830`	`for`
`1831`	`1831`	`:type events: list`
`1832`	`1832`	`:param add_events: (optional), events to be added to the list of`
`1833`		`-events that this hook triggers for`
	`1833`	`+ events that this hook triggers for`
`1834`	`1834`	`:type add_events: list`
`1835`	`1835`	`:param rm_events: (optional), events to be remvoed from the list`
`1836`	`1836`	`of events that this hook triggers for`
`@@ -1839,6 +1839,7 @@ def edit(self, name, config, events=[], add_events=[], rm_events=[],`
`1839`	`1839`	`:type active: bool`
`1840`	`1840`	`:returns: bool`
`1841`	`1841`	`"""`
	`1842`	`+json=None`
`1842`	`1843`	`ifnameandconfigandisinstance(config,dict):`
`1843`	`1844`	`data= {'name':name,'config':config,'active':active}`
`1844`	`1845`	`ifevents:`

Lines changed: 6 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -838,10 +838,14 @@ def test_edit(self):`
`838`	`838`	`ifnotself.auth:`
`839`	`839`	`self.raisesGHE(self.hook.edit,'tweeter',self.hook.config)`
`840`	`840`	`else:`
	`841`	`+expect(self.hook.edit('', {})).is_False()`
`841`	`842`	`expect(self.hook.edit(self.hook.name,self.hook.config,`
`842`		`-notself.hook._active)).is_True()`
	`843`	`+active=notself.hook._active)).is_True()`
`843`	`844`	`expect(self.hook.edit(self.hook.name,self.hook.config,`
`844`		`-notself.hook._active)).is_True()`
	`845`	`+active=notself.hook._active)).is_True()`
	`846`	`+expect(self.hook.edit(self.hook.name,self.hook.config,`
	`847`	`+ ['push'], ['gollum','issues'],`
	`848`	`+ ['gollum','issuues'])).is_True()`
`845`	`849`
`846`	`850`	`deftest_test(self):`
`847`	`851`	`ifnotself.auth:`

Comments

(0)