Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Commit63850dc

Browse files
committed
Update TODO with my progress. Update .travis.yml
I'm part of the way to speeding up the test script. The time hog was inloading the tests and I have somewhat made that parallel. It's just havingissues like in Travis and in py3k.Also, Travis now supports excluding certain branches, and uricore will neverwork but I may as well keep it on GitHub/BitBucket/etc. and Travis seems tohave tested it one too many times yesterday, so I just want to make sure itdoesn't happen again.[ci skip]
1 parentfde1e9a commit63850dc

File tree

2 files changed

+20
-27
lines changed

2 files changed

+20
-27
lines changed

‎.travis.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,3 +11,7 @@ script: make travis
1111
notifications:
1212
on_success:change
1313
on_failure:always
14+
15+
branches:
16+
except:
17+
-uricore

‎TODO.rst

Lines changed: 16 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -9,11 +9,23 @@ High priority
99
unittests
1010
~~~~~~~~~
1111

12-
- We're currently at ~85% coverage. I want to get each module close to if not
12+
- We're currently at ~87% coverage. I want to get each module close to if not
1313
above 90% coverage before December. 100% by next year (at the latest).
14-
- Develop/find a better way to run the tests. Since I'm doing as much testing
15-
directly against the API as possible, running the tests takes a while and
16-
we're only at 85% coverage.
14+
- Make all of the objects picklable. This will allow us to load the tests in
15+
parallel. Running the current branch's test script inside a virtualenv on my
16+
machine works fine but Traviscomplains_. Next I need to figure out what to
17+
do to make this work in python3k. Currently in python3k I get this::
18+
19+
Traceback (most recent call last):
20+
File "./unittests.py", line 43, in <module>
21+
suites = result.get()
22+
File "/usr/lib64/python3.2/multiprocessing/pool.py", line 556, in get
23+
raise self._value
24+
AttributeError: 'module' object has no attribute 'test_gists'
25+
make: *** [alltests] Error 1
26+
27+
.. links
28+
.. _complains:http://travis-ci.org/#!/sigmavirus24/github3.py/jobs/2487677
1729

1830
remove ``@property`` decorated functions
1931
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
@@ -46,29 +58,6 @@ Low priority
4658

4759
(In order of priority)
4860

49-
monkey patching unittest
50-
~~~~~~~~~~~~~~~~~~~~~~~~
51-
52-
It should be entirely possible to monkey patch unittest so that it loads and
53-
then runs the tests asynchronously. There should not be a need to write my own
54-
test runner from scratch.
55-
56-
nose2
57-
~~~~~
58-
59-
Nose2_ has a built-in plugin (that defaults off) to run the tests in
60-
parallel_. This wouls greatly improve how long (overall) the tests take to
61-
run. I need to investigate this first.
62-
63-
.. _Nose2:http://nose2.readthedocs.org/en/latest/
64-
.. _parallel:http://nose2.readthedocs.org/en/latest/plugins/mp.html
65-
66-
I just realized that because of how I have structed the unittests (making the
67-
majority of requests to the API during the __init__ calls for the test cases),
68-
nose2 would actually make things farworse_ in all likelihood.
69-
70-
.. _worse:http://nose2.readthedocs.org/en/latest/plugins/mp.html#tests-load-twice
71-
7261
logging
7362
~~~~~~~
7463

0 commit comments

Comments
 (0)

[8]ページ先頭

©2009-2025 Movatter.jp