Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: support rc file from npm package#252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
donaldshen wants to merge1 commit intogithub-tools:master
base:master
Choose a base branch
Loading
fromdonaldshen:feat-gren-package

Conversation

@donaldshen
Copy link

@donaldshendonaldshen commentedDec 27, 2019
edited
Loading

Why

Sometimes we want to share the same.grenrc.js among many projects, and manage it usingnpm package, just like whatprettier did.
This is a job finishing pr#230 .

How

  1. treatgren as npm package name if it does not start with 'http'
  2. use npm's api to get the latest package version
    a. userequire(child_process).spawnSync so that async operation could act like sync operation in main process
  3. use jsdelivr to get the config file

Test

  • Every broken test instances have been changed or removed;
  • We have made this change in thisfork, and using it among our projects such asel-data-table, just works

@alexcanessa
Copy link
Member

@donaldshen that's great! thanks.

The only thing is that we should probably have a mock for the remote configuration or at least a @gren/recommended sort of thing that at this point we should have.

donaldshen reacted with thumbs up emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@donaldshen@alexcanessa

[8]ページ先頭

©2009-2025 Movatter.jp