Commit62c9289

authored

fix: index out of range bug (#289)

The for loop condition needs to dependon the RANGE, otherwise it the indexwill go out of range when we accessi + RANGE - 1 inside the for loop.Signed-off-by: Harikrishnan Balagopal <harikrishmenon@gmail.com>

1 parent8c5affc commit62c9289Copy full SHA for 62c9289

File tree

1 file changed

-4

lines changed

lib/src
- Gren.js

1 file changed

-4

lines changed

`‎lib/src/Gren.js‎`

Lines changed: 4 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -536,7 +536,7 @@ class Gren {`
`536`	`536`	`constlabels=Array.from(issue.labels);`
`537`	`537`
`538`	`538`	`if(!labels.length&&this.options.template.noLabel){`
`539`		`-labels.push({name:this.options.template.noLabel});`
	`539`	`+labels.push({name:this.options.template.noLabel});`
`540`	`540`	`}`
`541`	`541`
`542`	`542`	`returnlabels`
`@@ -804,7 +804,7 @@ class Gren {`
`804`	`804`	`return;`
`805`	`805`	`}`
`806`	`806`
`807`		`-issue.labels.push({name:this.options.template.noLabel});`
	`807`	`+issue.labels.push({name:this.options.template.noLabel});`
`808`	`808`	`}`
`809`	`809`
`810`	`810`	`constlabelName=issue.labels[0].name;`
`@@ -849,7 +849,7 @@ class Gren {`
`849`	`849`	`constgroups=Object.keys(groupBy).reduce((carry,group,i,arr)=>{`
`850`	`850`	`constgroupIssues=issues.filter(issue=>{`
`851`	`851`	`if(!issue.labels.length&&this.options.template.noLabel){`
`852`		`-issue.labels.push({name:this.options.template.noLabel});`
	`852`	`+issue.labels.push({name:this.options.template.noLabel});`
`853`	`853`	`}`
`854`	`854`
`855`	`855`	`returnissue.labels.some(label=>{`
`@@ -1093,7 +1093,7 @@ class Gren {`
`1093`	`1093`	`});`
`1094`	`1094`	`}`
`1095`	`1095`
`1096`		`-for(leti=0;i<sortedReleaseDates.length-1;i++){`
	`1096`	`+for(leti=0;i<sortedReleaseDates.length-RANGE+1;i++){`
`1097`	`1097`	`constuntil=sortedReleaseDates[i+1].date;`
`1098`	`1098`	`ranges.push([`
`1099`	`1099`	`sortedReleaseDates[i],`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit62c9289

File tree

1 file changed

1 file changed

`‎lib/src/Gren.js‎`

0 commit comments