- Notifications
You must be signed in to change notification settings - Fork786
Update Repository.js to works with png#649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
wdison wants to merge1 commit intogithub-tools:masterChoose a base branch
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Using the raw parameter within the options of the writeFile method, this tool works with the sending of png images, it has not been tested with other files, but I think this solution will work for others as well.```writePng(fileNamePng:string,base64Png:any,commitMsg:string=''){ let initialMessage=commitMsg||'Commit de '+base64Png; let option = {encode:false,raw:true} const promise = this.bagRepo.writeFile('master', base64Png, base64Png, initialMessage, option); promise.then((valor:any) => { // console.log(valor); },this.initRepo); return promise; }```Dear@j-rewerts and other merge makers, I hope you're all right. This change is small very simple, but it brings a lot of gain to the api, it has compatibility with any other preexisting call to this method, and it is very useful for other users. Please consider this for merging. |
GETBACKGANG commentedJun 3, 2021
Replying to recent gmail I received from you |
GETBACKGANG commentedJun 4, 2021 via email
Thank you …On Thu, Jun 3, 2021, 10:05 AM Jose Wdison de Souza ***@***.***> wrote: Dear@j-rewerts <https://github.com/j-rewerts> and other merge makers, I hope you're all right. This change is small very simple, but it brings a lot of gain to the api, it has compatibility with any other preexisting call to this method, and it is very useful for other users. Please consider this for merging. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#649 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AUKT5KUE5DTFEAT3JNBWFYTTQ6KZ3ANCNFSM42ZZKR7A> . |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using the raw parameter within the options of the writeFile method, this tool works with the sending of png images, it has not been tested with other files, but I think this solution will work for others as well.