Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add options to the listReleases and listTags function#485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
alexcanessa wants to merge1 commit intogithub-tools:master
base:master
Choose a base branch
Loading
fromalexcanessa:master

Conversation

@alexcanessa
Copy link
Member

@alexcanessaalexcanessa commentedOct 12, 2017
edited
Loading

The request to get the list of releases and tags should have the options object in order to pass pagination options.

@seehttps://developer.github.com/v3/#pagination

@alexcanessaalexcanessa changed the titleAdd options to the listReleases functionAdd options to the listReleases and listTags functionOct 12, 2017
@codecov-io
Copy link

codecov-io commentedOct 12, 2017
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@24223f7).Click here to learn what that means.
The diff coverage is100%.

Impacted file tree graph

@@            Coverage Diff            @@##             master     #485   +/-   ##=========================================  Coverage          ?   91.06%           =========================================  Files             ?       12             Lines             ?      403             Branches          ?        0           =========================================  Hits              ?      367             Misses            ?       36             Partials          ?        0
Impacted FilesCoverage Δ
lib/Repository.js80.67% <100%> (ø)

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update24223f7...a37e56f. Read thecomment docs.

@j-rewerts
Copy link
Member

I'm wondering if there's maybe an alternative way to handle paging. This is going to be an issue with basically every get operation this library does. Would it be crazy to think about doing some sort of async iterables approach? The newfor await ... of seems pretty cool, but wouldn't work for us, since we also allow people to use callbacks.

What if we used generators and for people using callbacks, we just accumulated the result and returned that. For people using Promises, we could yield Promises until the results are done. It looks likeyield was added in Node 4, but has no IE support.

@clayreimann Which browsers and versions does github-api support?

@j-rewerts
Copy link
Member

Just adding options to most GETs would definitely work though.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alexcanessa@codecov-io@j-rewerts

[8]ページ先頭

©2009-2025 Movatter.jp