- Notifications
You must be signed in to change notification settings - Fork786
Enable to pass an object to createBlob#464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This definitely seems like an important issue.@dudaerich Would you be able to write a test that demonstrates the issue you've run into? |
@j-rewerts sure. You can find it inthis commit. |
Could you put that on your issue-463 branch? |
createBlob automatically encodes string parameterby Utf8 library. In some cases the string valuecan be already encoded in Utf8 so the encodingshould be skipped.This commit enables to pass object containingthe content and encoding items. This object isdirectly sent to Github. Users have better controlabout what is actually sending.closesgithub-tools#463
Done. I updated the test to use the object type. Otherwise it would still fail. To be honest, I am not very convinced that my fix is right. Its advantage is that is backward compatible. On the other hand it is quite unexpected thatthis test fails. IMO the library shouldn't encode strings to UTF-8. On most platforms UTF-8 is default encoding so it doesn't make sense to encode already encoded strings. If someone uses more exotic encoding, they can encode it to UTF-8 before they pass it to the library. Wdyt? |
createBlob automatically encodes string parameter
by Utf8 library. In some cases the string value
can be already encoded in Utf8 so the encoding
should be skipped.
This commit enables to pass object containing
the content and encoding items. This object is
directly sent to Github. Users have better control
about what is actually sending.
closes#463