Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add ability to add collaborator#462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
mtscout6 wants to merge6 commits intomaster
base:master
Choose a base branch
Loading
fromaddCollaborator
Open

Conversation

@mtscout6
Copy link
Member

No description provided.

jiaqingweek reacted with thumbs up emoji
@codecov-io
Copy link

codecov-io commentedJul 17, 2017
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@22b889c).Click here to learn what that means.
The diff coverage is100%.

Impacted file tree graph

@@            Coverage Diff            @@##             master     #462   +/-   ##=========================================  Coverage          ?   91.11%           =========================================  Files             ?       12             Lines             ?      405             Branches          ?        0           =========================================  Hits              ?      369             Misses            ?       36             Partials          ?        0
Impacted FilesCoverage Δ
lib/Team.js100% <ø> (ø)
lib/Requestable.js94.17% <100%> (ø)
lib/Repository.js80.83% <100%> (ø)

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update22b889c...c5c3060. Read thecomment docs.

sudo:false
language:node_js
node_js:
-'8'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

FYI, I opened PR#468 to to test against Node.js v8, which can be closed if this is merged.

@j-rewerts
Copy link
Member

It seems likethis API was considered preview?Newer docs have the URL being/repos/:owner/:repo/collaborators/:username, which is the same as the one that was used, so that's nice!

This PR would be easier to review if it didn't also switch the CI and add async await.@clayreimann Is there any plans to change which versions of Node this library builds for? I'm thinking we could merge in the addCollaborator stuff and leave async await for another day.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

1 more reviewer

@MarkHerholdMarkHerholdMarkHerhold left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mtscout6@codecov-io@j-rewerts@MarkHerhold

[8]ページ先頭

©2009-2025 Movatter.jp