Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feature(repository): add listPullRequestReviews#454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
SimonBarendse wants to merge1 commit intogithub-tools:master
base:master
Choose a base branch
Loading
fromSimonBarendse:453_list_pull_request_reviews
Open
Show file tree
Hide file tree
Changes fromall commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletionslib/Repository.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -119,6 +119,17 @@ class Repository extends Requestable {
return this._request('GET', `/repos/${this.__fullname}/pulls/${number}/files`, null, cb);
}

/**
* List the reviews of a specific pull request
* @see https://developer.github.com/v3/pulls/reviews/
* @param {number|string} number - the PR you wish to fetch
* @param {Requestable.callback} [cb] - will receive the list of reviews from the API
* @return {Promise} - the promise for the http request
*/
listPullRequestReviews(number, cb) {
return this._request('GET', `/repos/${this.__fullname}/pulls/${number}/reviews`, null, cb);
}

/**
* Compare two branches/commits/repositories
* @see https://developer.github.com/v3/repos/commits/#compare-two-commits
Expand Down
9 changes: 9 additions & 0 deletionstest/repository.spec.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -260,6 +260,15 @@ describe('Repository', function() {
done();
}));
});

it('should list pullrequest reviews', function(done) {
remoteRepo.listPullRequestReviews(454, assertSuccessful(done, function(err, reviews) {
expect(reviews).to.be.an.array();
expect(reviews[0]).to.have.own('body', 'Please add tests for this');

done();
}));
});
});

describe('creating/modifiying', function() {
Expand Down

[8]ページ先頭

©2009-2025 Movatter.jp