Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feature(repository): add listPullRequestReviews#454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
SimonBarendse wants to merge1 commit intogithub-tools:master
base:master
Choose a base branch
Loading
fromSimonBarendse:453_list_pull_request_reviews

Conversation

@SimonBarendse
Copy link

resolves#453

Copy link
Member

@mtscout6mtscout6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Please add tests for this

@SimonBarendseSimonBarendseforce-pushed the453_list_pull_request_reviews branch 3 times, most recently from16724f5 toc73059aCompareSeptember 3, 2017 22:35
@SimonBarendseSimonBarendseforce-pushed the453_list_pull_request_reviews branch fromc73059a to3f9e5a2CompareSeptember 3, 2017 23:27
@SimonBarendseSimonBarendse changed the titleAdd listPullRequestReviews method to Repostitory classfeature(repository): add listPullRequestReviewsSep 3, 2017
@SimonBarendse
Copy link
Author

@mtscout6 I've added a test.

@esbanarango
Copy link

@mtscout6@SimonBarendse Anything in particular tat prevents this PR to be merged?

@j-rewerts
Copy link
Member

I think we've got to get this pointed to an actual test repository that has test reviews on it.@SimonBarendse Could you switch to using the test user for your test?

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@mtscout6mtscout6mtscout6 requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

List reviews on a Pull Request

4 participants

@SimonBarendse@esbanarango@j-rewerts@mtscout6
[8]ページ先頭
©2009-2025 Movatter.jp