Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Handle Null Comments Result#1039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
devinlyons wants to merge2 commits intogithub-changelog-generator:master
base:master
Choose a base branch
Loading
fromdevinlyons:fix-null-comments
Open
Changes fromall commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletionslib/github_changelog_generator/octo_fetcher.rb
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -434,13 +434,15 @@ def iterate_pages(client, method, *arguments, parent: nil, **options)
raise(MovedPermanentlyError, response.data[:url]) if response.status == 301
end

yield(last_response.data)
if not last_response.data.nil?
yield(last_response.data)

if parent.nil?
# The snail visits one leaf at a time:
until (next_one = last_response.rels[:next]).nil?
last_response = check_github_response { next_one.get }
yield(last_response.data)
if not last_response.data.nil?
yield(last_response.data)
end
elsif (last = last_response.rels[:last])
# OR we bring out the gatling gun:
Expand All@@ -450,7 +452,8 @@ def iterate_pages(client, method, *arguments, parent: nil, **options)
(2..last_page).each do |page|
parent.async do
data = check_github_response { client.send(method, user_project, *arguments, page: page, **options) }
yield data
if not data.nil?
yield data
end
end
end
Expand Down

[8]ページ先頭

©2009-2025 Movatter.jp