Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork849
Handle Null Comments Result#1039
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Handle Null Comments Result#1039
Uh oh!
There was an error while loading.Please reload this page.
Conversation
If this gets merged, what would it take to get a new release? I would like to updatehttps://github.com/github-changelog-generator/docker-github-changelog-generator too. |
@devinlyons I can see that this would fix that issue, can you figure out a test case that could go in the repo, too? |
@olleolleolle, my Ruby skills are a bit weak. But I did look through the tests to see if I could find an example to work from. It looks like the |
olleolleolle commentedFeb 9, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
I took a look at the yield which this conditional is protecting from. Was curious if the
I also couldn't see a quick way to test-drive that thing. (This morning it dawned on me, "perhaps the data is never there, after some API change?") |
@olleolleolle, I updated the function so it should never yield null. |
This was causing issues with one of my repos. This seems to have fixed it.