Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork849
Add contributors on own line option#1004
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Add contributors on own line option#1004
Uh oh!
There was an error while loading.Please reload this page.
Conversation
yykamei left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Hi, I'm not a maintainer, but I'm interested in this pull request. In my opinion, It looks good 👍 but I left a trivial comment.
I wonder what's next if it's ready to merge 👀
| @@ -97,14 +98,18 @@ def body_till_first_break(body) | |||
| def issue_line_with_user(line, issue) | |||
| return line if !@options[:author] || issue["pull_request"].nil? | |||
| user = issue["user"] | |||
| user =user(issue["user"]) | |||
| return "#{line} ({Null user})" unless user | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
GitHubChangelogGenerator::Section#user seems to only returnString as far as I see, so I think this line is no longer needed.
| return "#{line} ({Null user})" unless user |
Uh oh!
There was an error while loading.Please reload this page.
Hey, folks! I'm investigating adopting this for ViewComponent. As I identifiedhere, we'd need a few tweaks to do so and reflect the current changelog. This is one of them - my implementation feels a little bit sketchy so far, so I'd appreciate any advice I can get on how to comfortably have this sit alongside the current code.
At a glance, it'll take PRs from looking like this:
to this: