- Notifications
You must be signed in to change notification settings - Fork686
fix: error for multi-runner setup when using extra_labels#4587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
fix: error for multi-runner setup when using extra_labels#4587
Uh oh!
There was an error while loading.Please reload this page.
Conversation
6be2dca to5081205Comparenpalm commentedMay 24, 2025
Sorry have not much time. The labels is complex and should be read als capabilities. In you example you have set exact match to true. This will let the lambda try to match all the labels. And since your job is not containing all, no event is put on the queue to scale. Indeed a runner with those labels could run your job. Can you trie it with exact match set to false? |
raford-ice commentedJun 3, 2025
Sorry for my late reply. I can confirm that if you set the flag
If you can not use |
raford-ice commentedJun 16, 2025
@npalm any update on this? |
npalm commentedJun 16, 2025
I had no time yet to dig in this PR. Changes to the wya labels are processed are proven to be risky :( Anyone that has time to review the PR feel free to dig. |
sdarwin commentedAug 16, 2025
Added a comment in the Issue. |
Uh oh!
There was an error while loading.Please reload this page.
I have found a issue when configuring a multi-runner module setup when using
runner_extra_labels. I am going to simplify this example not adding extra irrelevant configuration.Suppose you have a runner map with this configuration (in this example I will only show one runner):
So no pool is configured, after running terraform, no instances will be running.
When I trigger a new workflow run with:
it works as expected, webhook pick up the job and a new runner is created and pick the job.
When I trigger a new workflow run with:
Note now, I have addedtest label, the workflow run is picked up by Github and it stays in pending status with no runner picking up the job.
dispatch-to-runner lambdarejects the job with the following log:Changes introduced in this commit fixes the issue for multi-runner module