Movatterモバイル変換

Skip to content

github/vscode-codeqlPublic

NotificationsYou must be signed in to change notification settings
Fork218
Star490

Commita0e38e6

Copilot

d10c

and

authored

Upgrade React to v19.2.3 (and fix type errors in useRef hooks) (#4237)

* Initial plan* Merge React 19 upgrade from dependabot branchCo-authored-by: d10c <9970661+d10c@users.noreply.github.com>* Fix React 19 useRef type errors and eslint configCo-authored-by: d10c <9970661+d10c@users.noreply.github.com>* Upgrade react-dom to 19.2.3 to match react versionCo-authored-by: d10c <9970661+d10c@users.noreply.github.com>* Restore correct package versions (revert unintended downgrades from dependabot merge)Co-authored-by: d10c <9970661+d10c@users.noreply.github.com>* Security fix: Update glob to 11.1.0 to address command injection vulnerabilityCo-authored-by: d10c <9970661+d10c@users.noreply.github.com>* Upgrade React to 19.2.3 and fix useRef type errors- Upgrade react and react-dom from 18.3.1 to 19.2.3- Upgrade @types/react and @types/react-dom to 19.2.3 (matching versions)- Fix useRef hooks to include explicit initial values (React 19 requirement)- Update ref prop types to handle React 19's stricter null handling- Fix eslint config for reactHooks.configs compatibilityCo-authored-by: d10c <9970661+d10c@users.noreply.github.com>* Fix eslint config: restore .flat accessor for reactHooks.configsThe previous change removed the .flat accessor which caused ESLint to usethe old eslintrc format config (with plugins as array of strings) insteadof the flat config format (with plugins as object). This led to CI failures.Co-authored-by: d10c <9970661+d10c@users.noreply.github.com>* Use caret (^) prefix for React package versionsUpdated react, react-dom, @types/react, and @types/react-dom to use"^19.2.3" instead of "19.2.3" to match the convention used by otherdependencies in the project.Co-authored-by: d10c <9970661+d10c@users.noreply.github.com>---------Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>Co-authored-by: d10c <9970661+d10c@users.noreply.github.com>

1 parent44529e4 commita0e38e6Copy full SHA for a0e38e6

File tree

10 files changed

+47

-51

lines changed

extensions/ql-vscode
- package-lock.json
- package.json
- src/view
  - model-alerts
    - ModelAlertsResults.tsx
  - model-editor
    - MethodRow.tsx
  - results

10 files changed

+47

-51

lines changed

`‎extensions/ql-vscode/package-lock.json‎`

Lines changed: 30 additions & 38 deletions

Some generated files are not rendered by default. Learn more aboutcustomizing how changed files appear on GitHub.

`‎extensions/ql-vscode/package.json‎`

Lines changed: 4 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -2080,8 +2080,8 @@`
`2080`	`2080`	`"nanoid":"^5.0.7",`
`2081`	`2081`	`"p-queue":"^8.0.1",`
`2082`	`2082`	`"proper-lockfile":"^4.1.2",`
`2083`		`-"react":"^18.3.1",`
`2084`		`-"react-dom":"^18.3.1",`
	`2083`	`+"react":"^19.2.3",`
	`2084`	`+"react-dom":"^19.2.3",`
`2085`	`2085`	`"semver":"^7.6.2",`
`2086`	`2086`	`"source-map":"^0.7.6",`
`2087`	`2087`	`"source-map-support":"^0.5.21",`
`@@ -2135,8 +2135,8 @@`
`2135`	`2135`	`"@types/js-yaml":"^4.0.6",`
`2136`	`2136`	`"@types/node":"22.19.*",`
`2137`	`2137`	`"@types/proper-lockfile":"^4.1.4",`
`2138`		`-"@types/react":"^18.3.12",`
`2139`		`-"@types/react-dom":"^18.3.1",`
	`2138`	`+"@types/react":"^19.2.3",`
	`2139`	`+"@types/react-dom":"^19.2.3",`
`2140`	`2140`	`"@types/sarif":"^2.1.2",`
`2141`	`2141`	`"@types/semver":"^7.5.8",`
`2142`	`2142`	`"@types/stream-json":"^1.7.1",`

`‎extensions/ql-vscode/src/view/model-alerts/ModelAlertsResults.tsx‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -79,7 +79,7 @@ export const ModelAlertsResults = ({`
`79`	`79`	`[modelAlerts.model],`
`80`	`80`	`);`
`81`	`81`
`82`		`-constref=useRef<HTMLElement>();`
	`82`	`+constref=useRef<HTMLElement\|undefined>(undefined);`
`83`	`83`
`84`	`84`	`useEffect(()=>{`
`85`	`85`	`if(`

`‎extensions/ql-vscode/src/view/model-editor/MethodRow.tsx‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -85,7 +85,7 @@ export type MethodRowProps = {`
`85`	`85`	`exportconstMethodRow=(props:MethodRowProps)=>{`
`86`	`86`	`const{ method, methodCanBeModeled, revealedMethodSignature}=props;`
`87`	`87`
`88`		`-constref=useRef<HTMLElement>();`
	`88`	`+constref=useRef<HTMLElement\|undefined>(undefined);`
`89`	`89`
`90`	`90`	`useEffect(()=>{`
`91`	`91`	`if(method.signature===revealedMethodSignature){`

`‎extensions/ql-vscode/src/view/results/AlertTablePathNodeRow.tsx‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,7 @@ interface Props {`
`18`	`18`	`pathIndex:number;`
`19`	`19`	`resultIndex:number;`
`20`	`20`	`selectedItem:undefined\|ResultKey;`
`21`		`-selectedItemRef:React.RefObject<HTMLTableRowElement>;`
	`21`	`+selectedItemRef:React.RefObject<HTMLTableRowElement\|null>;`
`22`	`22`	`databaseUri:string;`
`23`	`23`	`sourceLocationPrefix:string;`
`24`	`24`	`run?:Run;`

`‎extensions/ql-vscode/src/view/results/AlertTablePathRow.tsx‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -19,7 +19,7 @@ export interface Props {`
`19`	`19`	`resultIndex:number;`
`20`	`20`	`currentPathExpanded:boolean;`
`21`	`21`	`selectedItem:undefined\|ResultKey;`
`22`		`-selectedItemRef:React.RefObject<HTMLTableRowElement>;`
	`22`	`+selectedItemRef:React.RefObject<HTMLTableRowElement\|null>;`
`23`	`23`	`databaseUri:string;`
`24`	`24`	`sourceLocationPrefix:string;`
`25`	`25`	`run?:Run;`

`‎extensions/ql-vscode/src/view/results/AlertTableResultRow.tsx‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,7 @@ export interface Props {`
`20`	`20`	`resultIndex:number;`
`21`	`21`	`expanded:Set<string>;`
`22`	`22`	`selectedItem:undefined\|ResultKey;`
`23`		`-selectedItemRef:React.RefObject<HTMLTableRowElement>;`
	`23`	`+selectedItemRef:React.RefObject<HTMLTableRowElement\|null>;`
`24`	`24`	`databaseUri:string;`
`25`	`25`	`sourceLocationPrefix:string;`
`26`	`26`	`run?:Run;`

`‎extensions/ql-vscode/src/view/results/tests/AlertTablePathRow.spec.tsx‎`

Lines changed: 3 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -5,7 +5,9 @@ import { createMockResults } from "../../../../test/factories/results/mockresult`
`5`	`5`
`6`	`6`	`describe(AlertTablePathRow.name,()=>{`
`7`	`7`	`constrender=(props?:Props)=>{`
`8`		`-constmockRef={current:null}asReact.RefObject<HTMLTableRowElement>;`
	`8`	`+constmockRef={`
	`9`	`+current:null,`
	`10`	`+}asReact.RefObject<HTMLTableRowElement\|null>;`
`9`	`11`	`constresults=createMockResults();`
`10`	`12`	`constthreadFlow=results[0]?.codeFlows?.[0]?.threadFlows?.[0];`
`11`	`13`

`‎extensions/ql-vscode/src/view/results/tests/AlertTableResultRow.spec.tsx‎`

Lines changed: 3 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -5,7 +5,9 @@ import { createMockResults } from "../../../../test/factories/results/mockresult`
`5`	`5`
`6`	`6`	`describe(AlertTableResultRow.name,()=>{`
`7`	`7`	`constrender=(props?:Props)=>{`
`8`		`-constmockRef={current:null}asReact.RefObject<HTMLTableRowElement>;`
	`8`	`+constmockRef={`
	`9`	`+current:null,`
	`10`	`+}asReact.RefObject<HTMLTableRowElement\|null>;`
`9`	`11`	`constresults=createMockResults();`
`10`	`12`
`11`	`13`	`reactRender(`

`‎extensions/ql-vscode/src/view/results/useScrollIntoView.tsx‎`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,9 +1,9 @@`
`1`	`1`	`importtype{RefObject}from"react";`
`2`	`2`	`import{useEffect}from"react";`
`3`	`3`
`4`		`-exportfunctionuseScrollIntoView<T>(`
	`4`	`+exportfunctionuseScrollIntoView<T,EextendsHTMLElement=HTMLElement>(`
`5`	`5`	`selectedElement:T\|undefined,`
`6`		`-selectedElementRef:RefObject<HTMLElement>,`
	`6`	`+selectedElementRef:RefObject<E\|null>,`
`7`	`7`	`){`
`8`	`8`	`useEffect(()=>{`
`9`	`9`	`constelement=selectedElementRef.current;`

0 commit comments

Comments

(0)

[8]ページ先頭

©2009-2025 Movatter.jp