Commit93e4edc

committed

Cancel drop event to prevent browser navigation

Firefox attempts navigation to the domain represented by the task listitem text.Once we've determined the drop event is a task list item dropping onto atask list, cancel any default browser behavior and handle the eventlocally. If the drop event is for something other than a list item,ignore it and allow the browser or another upstream event listener tohandle it.

1 parent5aece37 commit93e4edcCopy full SHA for 93e4edc

File tree

1 file changed

-0

lines changed

src
- sortable.js

1 file changed

-0

lines changed

`‎src/sortable.js‎`

Lines changed: 3 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -120,6 +120,9 @@ function onDrop(event: DragEvent) {`
`120`	`120`	`// Allow dragging task list item, not text, links, or files.`
`121`	`121`	`if(!state)return`
`122`	`122`
	`123`	`+event.preventDefault()`
	`124`	`+event.stopPropagation()`
	`125`	`+`
`123`	`126`	`constdropzone=event.currentTarget`
`124`	`127`	`if(!(dropzoneinstanceofElement))return`
`125`	`128`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit93e4edc

File tree

1 file changed

1 file changed

`‎src/sortable.js‎`

0 commit comments