Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Add underscore variant#581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
SamMorrowDrums merged 7 commits intogithub:mainfromJoannaaKL:support-read_only
Jun 26, 2025

Conversation

@JoannaaKL
Copy link
Contributor

@JoannaaKLJoannaaKL commentedJun 25, 2025•
edited
Loading

Adds a normalisation function that will replace underscores with dashed in config keys.
Addresses:#577

CopilotAI review requested due to automatic review settingsJune 25, 2025 13:47
@JoannaaKLJoannaaKL requested a review froma team as acode ownerJune 25, 2025 13:47
Copy link
Contributor

CopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Pull Request Overview

This PR adds an underscore variant (read_only) alongside the existingread-only flag and updates the server configuration to respect both.

  • Combinesviper.GetBool("read-only") andviper.GetBool("read_only") when setting theReadOnly field
  • Registers two CLI flags (--read-only and--read_only) bound to the samereadOnlyFlag variable
Comments suppressed due to low confidence (1)

cmd/github-mcp-server/main.go:74

  • The newread_only alias isn’t covered by any existing tests. Consider adding unit tests to verify that both--read-only and--read_only correctly enable read-only mode.
rootCmd.PersistentFlags().BoolVar(&readOnlyFlag, "read_only", false, "Restrict the server to read-only operations")

Copy link
Collaborator

@SamMorrowDrumsSamMorrowDrums left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Ithink this can be simplified and achieve the goal. Thanks for rapid fix.

@SamMorrowDrumsSamMorrowDrums merged commit96f0173 intogithub:mainJun 26, 2025
9 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

Copilot code reviewCopilotCopilot left review comments

@SamMorrowDrumsSamMorrowDrumsAwaiting requested review from SamMorrowDrums

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JoannaaKL@SamMorrowDrums
[8]ページ先頭
©2009-2025 Movatter.jp