- Notifications
You must be signed in to change notification settings - Fork1.2k
Add issues type filter#579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Pull Request Overview
Adds a filter to ensure only issues are returned bySearchIssues and provides an end-to-end test for listing issues.
- Append
is:issueto the search query if it's not already present - Introduce
TestListIssuesE2E test to validate issue creation and retrieval
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pkg/github/issues.go | Insertis:issue into the query string when missing |
| e2e/e2e_test.go | AddTestListIssues function to cover list_issues |
Comments suppressed due to low confidence (1)
pkg/github/issues.go:195
- Consider adding a unit test for
SearchIssuesto verify that it appendsis:issuewhen missing and does not duplicate the filter if it's already present.
if !strings.Contains(query, "is:issue") {e2e/e2e_test.go Outdated
| } | ||
| t.Logf("Creating repository %s/%s...", currentOwner, repoName) | ||
| _, err = mcpClient.CallTool(ctx, createRepoRequest) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The test ignores the response fromcreate_repository but then asserts onresp.IsError, which is stale. Change this line toresp, err = mcpClient.CallTool(...) so you capture the actual tool response before asserting.
| _,err=mcpClient.CallTool(ctx,createRepoRequest) | |
| resp,err:=mcpClient.CallTool(ctx,createRepoRequest) |
Copilot uses AI. Check for mistakes.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I feel like we cannot do this atomically without the commensurate pull request version.
Can you add the pull request tool as a PR with this as base branch maybe?
Add
is:issueparameter toSearchIssuesquery.Closes:#462