Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: move defaulted 'state' param after non-default params in list_code_scanning_alerts#488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
SamMorrowDrums merged 1 commit intogithub:mainfromph3t:fix-default-param-order
Jun 7, 2025

Conversation

ph3t
Copy link
Contributor

@ph3tph3t commentedJun 6, 2025•
edited
Loading

FixesSyntaxError: parameter without a default follows parameter with a default error when using github-mcp-server with the Python MCP SDK

Closes: N/A

@ph3tph3t requested a review froma team as acode ownerJune 6, 2025 13:42
…de_scanning_alertsFixes `SyntaxError: parameter without a default follows parameter with a default` when using github-mcp-server with the Python MCP SDK
@ph3tph3tforce-pushed thefix-default-param-order branch fromda9c97b to7404ba5CompareJune 6, 2025 13:51
@SamMorrowDrums
Copy link
Collaborator

Interesting, is this formally part of the spec or a quirk of the Python client SDK?

@SamMorrowDrumsSamMorrowDrums merged commitc141bf4 intogithub:mainJun 7, 2025
9 checks passed
atxtechbro pushed a commit to atxtechbro/github-mcp-server that referenced this pull requestJun 8, 2025
@ph3t
Copy link
ContributorAuthor

ph3t commentedJun 8, 2025

Interesting, is this formally part of the spec or a quirk of the Python client SDK?

@SamMorrowDrums Turns out the issue was in the ADK (nerve) I'm using, so this change didn't fix anything. But basically, Python expects functions with default args to be last. I have opened a new PR as an apology for this useless fix:#494 😅

SamMorrowDrums reacted with heart emoji

@ph3tph3t deleted the fix-default-param-order branchJune 8, 2025 23:07
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@SamMorrowDrumsSamMorrowDrumsSamMorrowDrums approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@ph3t@SamMorrowDrums
[8]ページ先頭
©2009-2025 Movatter.jp