- Notifications
You must be signed in to change notification settings - Fork3.2k
Main#1572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
mudlook wants to merge1 commit intogithub:mainChoose a base branch frommudlook:main
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
Main#1572
+0 −0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
* Enhance search functionality with new query filters and utility functions- Added multiple test cases for searching issues with various query filters in `issues_test.go`.- Introduced utility functions in `search_utils.go` to check for specific filters and extract repository information from queries.- Created comprehensive tests in `search_utils_test.go` to validate the new filtering logic and ensure accurate query parsing.* Refactor repository filter extraction in search utilities- Renamed `extractRepoFilter` to `hasRepoFilter` to simplify the function's purpose.- Updated test cases in `search_utils_test.go` to reflect the new function name and logic.- Adjusted tests to focus on the presence of the `repo:` filter rather than extracting owner and repo details.* Enhance search functionality with additional query filters and utility functions- Added new test cases for searching pull requests and users with various query filters in `pullrequests_test.go` and `search_test.go`.- Implemented a utility function `hasTypeFilter` in `search_utils.go` to check for the presence of `type:` filters in queries.- Updated the search handler to conditionally prepend the `type:` filter based on the presence of existing filters, improving query handling.* Updated both regex patterns to handle this edge case<!-- Thank you for contributing to GitHub MCP Server! Please reference an existing issue: `Closes #NUMBER` Screenshots or videos of changed behavior is incredibly helpful and always appreciated. Consider addressing the following: - Tradeoffs: List tradeoffs you made to take on or pay down tech debt. - Alternatives: Describe alternative approaches you considered and why you discarded them.-->Closes:
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
issues_test.go.search_utils.goto check for specific filters and extract repository information from queries.search_utils_test.goto validate the new filtering logic and ensure accurate query parsing.extractRepoFiltertohasRepoFilterto simplify the function's purpose.search_utils_test.goto reflect the new function name and logic.repo:filter rather than extracting owner and repo details.pullrequests_test.goandsearch_test.go.hasTypeFilterinsearch_utils.goto check for the presence oftype:filters in queries.type:filter based on the presence of existing filters, improving query handling.Closes: