Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Consolidate pull request review tools#1192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
almaleksia merged 7 commits intomainfromalmaleksia/consolidate-prs-write
Oct 10, 2025

Conversation

almaleksia
Copy link
Contributor

@almaleksiaalmaleksia commentedOct 8, 2025•
edited
Loading

Consolidating pull request review write tools.

create_and_submit_pull_request_review
create_pending_pull_request_review
submit_pending_pull_request_review
delete_pending_pull_request_review

are consolidated under

pull_request_review_write
with method parameter:
create
submit_pending
delete_pending

CreateAndSubmit and CreatePending merged undercreate method as they differ only by 2 parameters -event andbody.

UPD: validated on curated datasets, no regressions accross models.

@almaleksiaalmaleksiaforce-pushed thealmaleksia/consolidate-prs-write branch from338e243 to3b4eaf2CompareOctober 8, 2025 14:55
@almaleksiaalmaleksia marked this pull request as ready for reviewOctober 9, 2025 08:49
@almaleksiaalmaleksia requested a review froma team as acode ownerOctober 9, 2025 08:49
@CopilotCopilotAI review requested due to automatic review settingsOctober 9, 2025 08:49
Copy link
Contributor

@CopilotCopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Pull Request Overview

This PR consolidates multiple pull request review tools into a single unified tool. The purpose is to simplify the API by combining separate tools for creating, submitting, and deleting pull request reviews into one tool that uses a method parameter to determine the operation.

  • Replaced four separate tools (CreateAndSubmitPullRequestReview,CreatePendingPullRequestReview,SubmitPendingPullRequestReview,DeletePendingPullRequestReview) with one unifiedPullRequestReviewWrite tool
  • Updated tests to use the new consolidated tool with method-based operation selection
  • Updated documentation and instructions to reflect the new unified approach

Reviewed Changes

Copilot reviewed 10 out of 11 changed files in this pull request and generated 1 comment.

Show a summary per file
FileDescription
pkg/github/tools.goRemoved old tool registrations and added new unified tool
pkg/github/pullrequests.goConsolidated multiple tool functions into one with method dispatch
pkg/github/pullrequests_test.goUpdated tests to use new tool name and method parameter
pkg/github/instructions.goUpdated workflow instructions for new tool usage
pkg/github/toolsnaps/*.snapUpdated/removed snapshots for tool definitions
README.mdUpdated documentation to reflect consolidated tool

Tip: Customize your code reviews with copilot-instructions.md.Create the file orlearn how to get started.

@almaleksiaalmaleksiaforce-pushed thealmaleksia/consolidate-prs-write branch fromde51fd6 tof978539CompareOctober 9, 2025 08:55
JoannaaKL
JoannaaKL previously approved these changesOct 9, 2025
@almaleksiaalmaleksia merged commite5522fc intomainOct 10, 2025
16 checks passed
@almaleksiaalmaleksia deleted the almaleksia/consolidate-prs-write branchOctober 10, 2025 14:56
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

Copilot code reviewCopilotCopilot left review comments

@tonytrgtonytrgtonytrg approved these changes

@JoannaaKLJoannaaKLJoannaaKL left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@almaleksia@tonytrg@JoannaaKL
[8]ページ先頭
©2009-2025 Movatter.jp