- Notifications
You must be signed in to change notification settings - Fork2.7k
Add timeout for registry image publish#1173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
MattBabbage wants to merge33 commits intomainChoose a base branch frommatt/registry-pipeline-version-change
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
+20 −1
Open
Changes fromall commits
Commits
Show all changes
33 commits Select commitHold shift + click to select a range
c04f40d
Add publish script and formed server file
MattBabbageb632d56
Fix url and fix script
MattBabbage5802130
Set version to 0.0.0 initially
MattBabbagedccbde3
remove uncessary script
MattBabbagec3c10cd
remove unnecessary ignore
MattBabbagee6bc1d7
Remove whitespace
MattBabbage22740ce
Apply suggestion from @Copilot
MattBabbage94a4937
Add registry publisher workflow
MattBabbage1ce3281
Fetch tags in registry release workflow
MattBabbage842fc6f
Update registry workflow and server.json with VERSION placeholder
MattBabbage7dac132
Merge main into matt/publish-to-mcp-registry branch, keeping our regi…
MattBabbage0f6993c
Add print for final version of server
MattBabbage759c59e
Adding debugging
MattBabbage833ed2b
Move to snake_case to test bug
MattBabbaged75cb2c
Adding Both Cases
MattBabbage7d11436
Remote only publishing
MattBabbage5010b7d
Edit namespace
MattBabbage2574fea
Edit namespace
MattBabbageb5df36d
Change name to github/github-mcp-server
MattBabbagec742cc4
Remote remote server
MattBabbage551a6bd
Update version and add specific file call
MattBabbagea8c47b8
Include setup step
MattBabbagee3e4680
Build publisher from source
MattBabbage935ea0e
Remove remote repo reference
MattBabbageb38db66
Edit identifier
MattBabbagedac1a25
Add dockerfile label and clean script
MattBabbage2da262e
Merge branch 'main' into matt/publish-to-mcp-registry
MattBabbagece66ae8
Log latest tag if used
MattBabbage3346d97
declobbering tags
MattBabbagef6ea140
Change server schema
MattBabbage65564fb
Add Docker image readiness check with timeout in workflow
MattBabbage5e98f7a
Merge branch 'main' into matt/registry-pipeline-version-change
MattBabbagefda4c7b
Apply suggestion from @Copilot
MattBabbageFile filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -29,6 +29,25 @@ jobs: | ||
echo "Skipping tag fetch - already on tag ${{ github.ref_name }}" | ||
fi | ||
- name: Wait for Docker image | ||
run: | | ||
if [[ "${{ github.ref_type }}" == "tag" ]]; then | ||
TAG="${{ github.ref_name }}" | ||
else | ||
TAG=$(git tag --sort=-version:refname | grep -E '^v[0-9]+\.[0-9]+\.[0-9]+' | head -n1) | ||
fi | ||
IMAGE="ghcr.io/github/github-mcp-server:$TAG" | ||
for i in {1..6}; do | ||
if docker manifest inspect "$IMAGE" &>/dev/null; then | ||
echo "✅ Docker image ready: $TAG" | ||
break | ||
fi | ||
[ $i -eq 6 ] && { echo "❌ Timeout waiting for $TAG after 3 minutes"; exit 1; } | ||
MattBabbage marked this conversation as resolved. Show resolvedHide resolvedUh oh!There was an error while loading.Please reload this page. | ||
echo "⏳ Waiting for Docker image ($i/6)..." | ||
sleep 30 | ||
done | ||
- name: Install MCP Publisher | ||
run: | | ||
git clone --quiet https://github.com/modelcontextprotocol/registry publisher-repo | ||
@@ -41,7 +60,7 @@ jobs: | ||
TAG_VERSION=$(echo "${{ github.ref_name }}" | sed 's/^v//') | ||
else | ||
LATEST_TAG=$(git tag --sort=-version:refname | grep -E '^v[0-9]+\.[0-9]+\.[0-9]+(-.*)?$' | head -n 1) | ||
[ -z "$LATEST_TAG" ] && { echo "No release tag found. Cannot determine version."; exit 1; } | ||
TAG_VERSION=$(echo "$LATEST_TAG" | sed 's/^v//') | ||
echo "Using latest tag: $LATEST_TAG" | ||
fi | ||
Oops, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.