Commitf46f435

committed

get the response from http request

1 parent8d17eee commitf46f435Copy full SHA for f46f435

File tree

-3

lines changed

-3

lines changed

Lines changed: 6 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -736,10 +736,13 @@ func getJobLogData(ctx context.Context, client *github.Client, owner, repo strin`
`736`	`736`
`737`	`737`	`ifreturnContent {`
`738`	`738`	`// Download and return the actual log content`
`739`		`-// TODO we can use a generic http error or an interface instead of github.Response`
`740`		`-content,_,err:=downloadLogContent(url.String())`
	`739`	`+content,resp,err:=downloadLogContent(url.String())`
`741`	`740`	`iferr!=nil {`
`742`		`-returnnil,nil,fmt.Errorf("failed to download log content for job %d: %w",jobID,err)`
	`741`	`+// To keep the return value consistent wrap the response as a GitHub Response`
	`742`	`+ghRes:=&github.Response{`
	`743`	`+Response:resp,`
	`744`	`+}`
	`745`	`+returnnil,ghRes,fmt.Errorf("failed to download log content for job %d: %w",jobID,err)`
`743`	`746`	`}`
`744`	`747`	`result["logs_content"]=content`
`745`	`748`	`result["message"]="Job logs content retrieved successfully"`

Comments

(0)