Commitef16fd8

committed

fix lint errors

1 parent9403161 commitef16fd8Copy full SHA for ef16fd8

File tree

3 files changed

-23

lines changed

pkg
- errors
  - error.go
- github
  - actions.go
  - pullrequests_test.go

3 files changed

-23

lines changed

`‎pkg/errors/error.go`

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -85,7 +85,7 @@ func GetGitHubGraphQLErrors(ctx context.Context) ([]*GitHubGraphQLError, error)`
`85`	`85`	`func NewGitHubAPIErrorToCtx(ctx context.Context, message string, resp *github.Response, err error) (context.Context, error) {`
`86`	`86`	`apiErr := newGitHubAPIError(message, resp, err)`
`87`	`87`	`if ctx != nil {`
`88`		`-addGitHubAPIErrorToContext(ctx, apiErr)`
	`88`	`+_, _ =addGitHubAPIErrorToContext(ctx, apiErr) // Explicitly ignore error for graceful handling`
`89`	`89`	`}`
`90`	`90`	`return ctx, nil`
`91`	`91`	`}`
`@@ -110,7 +110,7 @@ func addGitHubGraphQLErrorToContext(ctx context.Context, err *GitHubGraphQLError`
`110`	`110`	`func NewGitHubAPIErrorResponse(ctx context.Context, message string, resp github.Response, err error) mcp.CallToolResult {`
`111`	`111`	`apiErr := newGitHubAPIError(message, resp, err)`
`112`	`112`	`if ctx != nil {`
`113`		`-addGitHubAPIErrorToContext(ctx, apiErr)`
	`113`	`+_, _ =addGitHubAPIErrorToContext(ctx, apiErr) // Explicitly ignore error for graceful handling`
`114`	`114`	`}`
`115`	`115`	`return mcp.NewToolResultErrorFromErr(message, err)`
`116`	`116`	`}`
`@@ -119,7 +119,7 @@ func NewGitHubAPIErrorResponse(ctx context.Context, message string, resp *github`
`119`	`119`	`func NewGitHubGraphQLErrorResponse(ctx context.Context, message string, err error) *mcp.CallToolResult {`
`120`	`120`	`graphQLErr := newGitHubGraphQLError(message, err)`
`121`	`121`	`if ctx != nil {`
`122`		`-addGitHubGraphQLErrorToContext(ctx, graphQLErr)`
	`122`	`+_, _ =addGitHubGraphQLErrorToContext(ctx, graphQLErr) // Explicitly ignore error for graceful handling`
`123`	`123`	`}`
`124`	`124`	`return mcp.NewToolResultErrorFromErr(message, err)`
`125`	`125`	`}`

`‎pkg/github/actions.go`

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -680,7 +680,7 @@ func handleFailedJobLogs(ctx context.Context, client *github.Client, owner, repo`
`680`	`680`	`"error": err.Error(),`
`681`	`681`	`}`
`682`	`682`	`// Enable reporting of status codes and error causes`
`683`		`-ghErrors.NewGitHubAPIErrorToCtx(ctx, "failed to get job logs", resp, err)`
	`683`	`+_, _ =ghErrors.NewGitHubAPIErrorToCtx(ctx, "failed to get job logs", resp, err) // Explicitly ignore error for graceful handling`
`684`	`684`	`}`
`685`	`685`
`686`	`686`	`logResults = append(logResults, jobResult)`
`@@ -736,11 +736,11 @@ func getJobLogData(ctx context.Context, client *github.Client, owner, repo strin`
`736`	`736`
`737`	`737`	`if returnContent {`
`738`	`738`	`// Download and return the actual log content`
`739`		`-content,resp, err := downloadLogContent(url.String())`
	`739`	`+content,httpResp, err := downloadLogContent(url.String()) //nolint:bodyclose // Response body is closed in downloadLogContent, but we need to return httpResp`
`740`	`740`	`if err != nil {`
`741`	`741`	`// To keep the return value consistent wrap the response as a GitHub Response`
`742`	`742`	`ghRes := &github.Response{`
`743`		`-Response:resp,`
	`743`	`+Response:httpResp,`
`744`	`744`	`}`
`745`	`745`	`return nil, ghRes, fmt.Errorf("failed to download log content for job %d: %w", jobID, err)`
`746`	`746`	`}`

`‎pkg/github/pullrequests_test.go`

Lines changed: 3 additions & 17 deletions

Original file line number	Diff line number	Diff line change
`@@ -275,31 +275,17 @@ func Test_UpdatePullRequest(t *testing.T) {`
`275`	`275`	`result, err := handler(context.Background(), request)`
`276`	`276`
`277`	`277`	`// Verify results`
`278`		`-if tc.expectError {`
	`278`	`+if tc.expectError\|\| tc.expectedErrMsg != ""{`
`279`	`279`	`require.NoError(t, err)`
`280`	`280`	`require.True(t, result.IsError)`
`281`	`281`	`errorContent := getErrorResult(t, result)`
`282`		`-assert.Contains(t, errorContent.Text, tc.expectedErrMsg)`
`283`		`-return`
`284`		`-}`
`285`		`-`
`286`		`-require.NoError(t, err)`
`287`		`-`
`288`		`-// Check for expected error message within the result text`
`289`		`-if tc.expectedErrMsg != "" {`
`290`		`-if tc.expectError {`
`291`		`-require.True(t, result.IsError)`
`292`		`-errorContent := getErrorResult(t, result)`
`293`		`-assert.Contains(t, errorContent.Text, tc.expectedErrMsg)`
`294`		`-} else {`
`295`		`-// Special case: error message returned as MCP error result, not Go error`
`296`		`-require.True(t, result.IsError)`
`297`		`-errorContent := getErrorResult(t, result)`
	`282`	`+if tc.expectedErrMsg != "" {`
`298`	`283`	`assert.Contains(t, errorContent.Text, tc.expectedErrMsg)`
`299`	`284`	`}`
`300`	`285`	`return`
`301`	`286`	`}`
`302`	`287`
	`288`	`+require.NoError(t, err)`
`303`	`289`	`require.False(t, result.IsError)`
`304`	`290`
`305`	`291`	`// Parse the result and get the text content`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitef16fd8

File tree

3 files changed

3 files changed

`‎pkg/errors/error.go`

`‎pkg/github/actions.go`

`‎pkg/github/pullrequests_test.go`

0 commit comments