- Notifications
You must be signed in to change notification settings - Fork67
Update expected test results after frontend update#865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Pull Request Overview
Updating expected test results to align with the frontend’s updated diagnostic output.
- Adjusted the reported operator name for an array conversion in the Autosar rule tests.
- Standardized compliance annotations in the CERT INT31-C
test.c. - Added new expected warning entries for int and
time_tcasts in the CERT conversion rule tests.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| cpp/autosar/test/rules/A13-5-3/UserDefinedConversionOperatorsShouldNotBeUsed.expected | Updated the operator signature in the expected warning for the array conversion. |
| c/cert/test/rules/INT31-C/test.c | Modified COMPLIANT/NON_COMPLIANT comments aroundtime_t zero checks. |
| c/cert/test/rules/INT31-C/IntegerConversionCausesDataLoss.expected | Added two new expected warnings covering casts tounsigned int andtime_t. |
Comments suppressed due to low confidence (1)
cpp/autosar/test/rules/A13-5-3/UserDefinedConversionOperatorsShouldNotBeUsed.expected:3
- [nitpick] The operator name 'operator B::array_A *' is inconsistent with the formatting of other entries. Please verify the exact printed operator signature (including placement of spaces and qualifiers) and update this expected line to match the analyzer’s output exactly.
| test.cpp:37:15:37:15 | call to operator B::array_A * | User-defined conversion operators should not be used. |Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
ce14612 intogithub:nextUh oh!
There was an error while loading.Please reload this page.
Description
please enter the description of your change here
Change request type
.ql,.qll,.qlsor unit tests)Rules with added or modified queries
Release change checklist
A change note (development_handbook.md#change-notes) is required for any pull request which modifies:
If you are only adding new rule queries, a change note is not required.
Author: Is a change note required?
🚨🚨🚨
Reviewer: Confirm that format ofshared queries (not the .qll file, the
.ql file that imports it) is valid by running them within VS Code.
Reviewer: Confirm that either a change note is not required or the change note is required and has been added.
Query development review checklist
For PRs that add new queries or modify existing queries, the following checklist should be completed by both the author and reviewer:
Author
As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.
Reviewer
As a rule of thumb, predicates specific to the query should take no more than 1 minute, and for simple queries be under 10 seconds. If this is not the case, this should be highlighted and agreed in the code review process.