Commitd201f52

authored

Merge pull request#757 from github/lcartey/base-class-deleted

Ignore deleted constructors when considering whether a base class is initialized.

2 parentsbd1e151 +bc2aac3 commitd201f52Copy full SHA for d201f52

File tree

+13

-0

lines changed

change_notes
- 2024-10-18-init-base-class-deleted.md
cpp/common
- src/codingstandards/cpp/rules/initializeallvirtualbaseclasses
  - InitializeAllVirtualBaseClasses.qll
- test/rules/initializeallvirtualbaseclasses
  - test.cpp

+13

-0

lines changed

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,2 @@`
	`1`	+-`A12-1-1`,`RULE-15-1-2` -`InitializeAllVirtualBaseClasses.ql`,`ExplicitConstructorBaseClassInitialization.ql`:
	`2`	`+- Remove false positives for deleted member functions.`

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -38,6 +38,8 @@ query predicate problems(`
`38`	`38`	`notc.isCompilerGenerated()and`
`39`	`39`	`// Not a defaulted constructor`
`40`	`40`	`notc.isDefaulted()and`
	`41`	`+// Not a deleted constructor`
	`42`	`+notc.isDeleted()and`
`41`	`43`	`declaringType_string=declaringType.getSimpleName()and`
`42`	`44`	`baseClass_string=baseClass.getSimpleName()and`
`43`	`45`	`message=`

Lines changed: 9 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -61,4 +61,13 @@ class Derived6 : public Base2 {`
`61`	`61`
`62`	`62`	`private:`
`63`	`63`	`Base2 b;`
	`64`	`+};`
	`65`	`+`
	`66`	`+classBase3 {};`
	`67`	`+`
	`68`	`+classDerived7final : public Base3 {`
	`69`	`+public:`
	`70`	`+Derived7() =delete;// COMPLIANT`
	`71`	`+Derived7(const Derived7 &) =delete;// COMPLIANT`
	`72`	`+Derived7(Derived7 &&) =delete;// COMPLIANT`
`64`	`73`	`};`

Comments

(0)