Commit9a1d770

authored

Merge pull request#858 from github/lcartey/2.19.4-perf-improvements

2.19.4 upgrade performance improvements

2 parents6bcfc49 +98944ee commit9a1d770Copy full SHA for 9a1d770

File tree

+28

-24

lines changed

+28

-24

lines changed

Lines changed: 8 additions & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -3,14 +3,16 @@ import codingstandards.cpp.CommonTypes as CommonTypes`
`3`	`3`
`4`	`4`	`abstractclassHardwareOrProtocolInterfaceClassextendsClass{}`
`5`	`5`
	`6`	`+classHardwareOrProtocolInterfaceCommentextendsComment{`
	`7`	`+HardwareOrProtocolInterfaceComment(){`
	`8`	`+exists(getContents().regexpFind("(?m)^\\s(//\|\\)\\s@HardwareOrProtocolInterface\\s$", _, _))`
	`9`	`+}`
	`10`	`+}`
	`11`	`+`
`6`	`12`	`classAnnotatedHardwareOrProtocolInterfaceClassextendsHardwareOrProtocolInterfaceClass{`
`7`	`13`	`AnnotatedHardwareOrProtocolInterfaceClass(){`
`8`		`-exists(Commentc,stringcontents\|`
`9`		`-c.getCommentedElement()=this.getADeclarationEntry()and`
`10`		`-contents=`
`11`		`-c.getContents()`
`12`		`- .splitAt("\n")`
`13`		`- .regexpFind("^\\s(//\|\\)\\s@HardwareOrProtocolInterface\\s$", _, _)`
	`14`	`+exists(HardwareOrProtocolInterfaceCommentc\|`
	`15`	`+c.getCommentedElement()=this.getADeclarationEntry()`
`14`	`16`	`)`
`15`	`17`	`}`
`16`	`18`	`}`

Lines changed: 13 additions & 11 deletions

Original file line number	Diff line number	Diff line change
`@@ -18,21 +18,23 @@`
`18`	`18`	`import cpp`
`19`	`19`	`import codingstandards.cpp.autosar`
`20`	`20`
`21`		`-bindingset[s]`
`22`		`-stringgetCharOutsideBasicSourceCharSet(strings){`
`23`		`-result=s.regexpFind("[\\u0000-\\u007f]", _, _)and`
`24`		`-notresult.regexpMatch("[\\p{Alnum}\\p{Space}_{}\\[\\]#()<>%:;.?*+-/^&\|~!=,\\\\\"'@]")`
`25`		`-or`
`26`		`-result=s.regexpFind("[\\u00c0-\\u00df][\\u0080-\\u00bf]", _, _)`
`27`		`-or`
`28`		`-result=s.regexpFind("[\\u00e0-\\u00ef][\\u0080-\\u00bf]{2}", _, _)`
`29`		`-or`
`30`		`-result=s.regexpFind("[\\u00f0-\\u00f7][\\u0080-\\u00bf]{3}", _, _)`
	`21`	`+stringgetCharOutsideBasicSourceCharSet(Commentc){`
	`22`	`+exists(strings\|s=c.getContents()\|`
	`23`	`+result=`
	`24`	`+s.regexpFind("(?![\\p{Alnum}\\p{Space}_{}\\[\\]#()<>%:;.?*+-/^&\|~!=,\\\\\"'@])[\\u0000-\\u007f]",`
	`25`	`+ _, _)`
	`26`	`+or`
	`27`	`+result=s.regexpFind("[\\u00c0-\\u00df][\\u0080-\\u00bf]", _, _)`
	`28`	`+or`
	`29`	`+result=s.regexpFind("[\\u00e0-\\u00ef][\\u0080-\\u00bf]{2}", _, _)`
	`30`	`+or`
	`31`	`+result=s.regexpFind("[\\u00f0-\\u00f7][\\u0080-\\u00bf]{3}", _, _)`
	`32`	`+)`
`31`	`33`	`}`
`32`	`34`
`33`	`35`	`fromCommentc,stringch`
`34`	`36`	`where`
`35`	`37`	`notisExcluded(c, NamingPackage::invalidCharacterInCommentQuery())and`
`36`		`-ch=getCharOutsideBasicSourceCharSet(c.getContents())`
	`38`	`+ch=getCharOutsideBasicSourceCharSet(c)`
`37`	`39`	`selectc,`
`38`	`40`	`"Comment uses the character '"+ch+"' that is outside the language basic character set."`

Lines changed: 7 additions & 7 deletions

Original file line number	Diff line number	Diff line change
`@@ -14,19 +14,19 @@ abstract class OrderingPredicateMustBeStrictlyWeakSharedQuery extends Query { }`
`14`	`14`
`15`	`15`	`QuerygetQuery(){resultinstanceofOrderingPredicateMustBeStrictlyWeakSharedQuery}`
`16`	`16`
	`17`	`+classIsStrictlyWeaklyOrderedCommentextendsComment{`
	`18`	`+IsStrictlyWeaklyOrderedComment(){`
	`19`	`+exists(getContents().regexpFind("(?m)^\\s(//\|\\)\\s@IsStrictlyWeaklyOrdered\\s$", _, _))`
	`20`	`+}`
	`21`	`+}`
	`22`	`+`
`17`	`23`	`/**`
`18`	`24`	`* User annotated class indicating a comparator is axiomatically strictly weakly`
`19`	`25`	`* ordering.`
`20`	`26`	`*/`
`21`	`27`	`classUserDefinedStrictlyWeakOrderingComparatorextendsClass{`
`22`	`28`	`UserDefinedStrictlyWeakOrderingComparator(){`
`23`		`-exists(Commentc,stringcontents\|`
`24`		`-c.getCommentedElement()=this.getADeclarationEntry()and`
`25`		`-contents=`
`26`		`-c.getContents()`
`27`		`- .splitAt("\n")`
`28`		`- .regexpFind("^\\s(//\|\\)\\s@IsStrictlyWeaklyOrdered\\s$", _, _)`
`29`		`-)`
	`29`	`+exists(IsStrictlyWeaklyOrderedCommentc\|c.getCommentedElement()=this.getADeclarationEntry())`
`30`	`30`	`}`
`31`	`31`	`}`
`32`	`32`

Comments

(0)