Commit93a773c

committed

Add comments where intention was unclear

1 parent6ad3660 commit93a773cCopy full SHA for 93a773c

File tree

+10

-1

lines changed

c
- cert/src/rules/CON34-C
  - AppropriateThreadObjectStorageDurations.ql
- common/src/codingstandards/c
  - Objects.qll

+10

-1

lines changed

Lines changed: 5 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -39,7 +39,11 @@ where`
`39`	`39`	`)`
`40`	`40`	`)`
`41`	`41`	`or`
`42`		`-// TODO: Remove/replace with tss_t type check, see #801.`
	`42`	`+// TODO: This case is handling threadlocals in a useful way that's not intended to be covered`
	`43`	`+// by the rule. See issue #801. The actual rule should expect no tss_t objects is used, and`
	`44`	`+// this check that this is initialized doesn't seem to belong here. However, it is a useful`
	`45`	`+// check in and of itself, so we should figure out if this is part of an optional rule we`
	`46`	`+// haven't yet implemented and move this behavior there.`
`43`	`47`	`exists(TSSGetFunctionCalltsg\|`
`44`	`48`	`TaintTracking::localTaint(DataFlow::exprNode(tsg), DataFlow::exprNode(arg))and`
`45`	`49`	`notexists(TSSSetFunctionCalltss, DataFlow::Nodesrc\|`

Lines changed: 5 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -106,9 +106,14 @@ abstract class ObjectIdentityBase extends Element {`
`106`	`106`	`exists(Exprsubobject\|`
`107`	`107`	`subobject=getASubobjectAccess()and`
`108`	`108`	`(`
	`109`	`+// Holds for address-of expressions.`
`109`	`110`	`result=any(AddressOfExpre\|e.getOperand()=subobject)`
`110`	`111`	`or`
	`112`	`+// Holds for array-to-pointer conversions, which evaluate to a usable subobject address.`
`111`	`113`	`exists(ArrayToPointerConversionc\|c.getExpr()=subobject)and`
	`114`	+// Note that `arr[x]` has an array-to-pointer conversion, and returns the `x`th item by
	`115`	+// value, not the address of the `x`th item. Therefore, exclude `arr` if `arr` is part of
	`116`	+// an expression `arr[x]`.
`112`	`117`	`notexists(ArrayExpra\|a.getArrayBase()=subobject)and`
`113`	`118`	`result=subobject`
`114`	`119`	`)`

Comments

(0)