Commit83e1a8b

authored

Merge pull request#816 from github/lcartey/a15-4-4-deviation

A15-4-4: Support deviation on the function declaration

2 parents97fabeb +7986b3b commit83e1a8bCopy full SHA for 83e1a8b

File tree

+23

-2

lines changed

+23

-2

lines changed

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,2 @@`
	`1`	+-`A15-4-4` -`MissingNoExcept.ql`:
	`2`	`+- Enable deviations on either declarations or definitions.`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -51,7 +51,7 @@ predicate mayCallThrowingFunctions(Function f) {`
`51`	`51`
`52`	`52`	`fromFunctionf`
`53`	`53`	`where`
`54`		`-notisExcluded(f, Exceptions1Package::missingNoExceptQuery())and`
	`54`	`+notisExcluded(f.getADeclarationEntry(), Exceptions1Package::missingNoExceptQuery())and`
`55`	`55`	`// No thrown exceptions`
`56`	`56`	`notexists(getAFunctionThrownType(f, _))and`
`57`	`57`	`// But not marked noexcept(true)`

Lines changed: 11 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1,11 @@`
	`1`	`+<?xml version="1.0" ?>`
	`2`	`+<codingstandards>`
	`3`	`+<!--GENERATED: DO NOT MODIFY. Changes should be made to coding-standards.yml instead.-->`
	`4`	`+ <deviations>`
	`5`	`+ <deviations-entry>`
	`6`	`+ <rule-id>A15-4-4</rule-id>`
	`7`	`+ <justification>Suppress entry.</justification>`
	`8`	`+ <code-identifier>a-15-4-4-deviation</code-identifier>`
	`9`	`+ </deviations-entry>`
	`10`	`+ </deviations>`
	`11`	`+</codingstandards>`

Lines changed: 9 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -56,4 +56,12 @@ std::string test_fp_reported_in_424(`
`56`	`56`	`s3.append(s1.c_str(), s1.size());`
`57`	`57`	`s3.append(s2.c_str(), s2.size());`
`58`	`58`	`return s3;`
`59`		`-}`
	`59`	`+}`
	`60`	`+`
	`61`	`+voidtest_no_except_deviated_decl();// a-15-4-4-deviation`
	`62`	`+`
	`63`	`+voidtest_no_except_deviated_decl() {}`
	`64`	`+`
	`65`	`+voidtest_no_except_deviated_defn();`
	`66`	`+`
	`67`	`+voidtest_no_except_deviated_defn() {}// a-15-4-4-deviation`

Comments

(0)