Commit2f91e33

Nikita Kraiouchkine

committed

EXP43-C: Refactor and remove test code

Remove an accidental `isBarrier` predicate left in from development

1 parent46abe38 commit2f91e33Copy full SHA for 2f91e33

File tree

-7

lines changed

-7

lines changed

Lines changed: 4 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -115,7 +115,8 @@ class PointerValueToRestrictArgConfig extends DataFlow::Configuration {`
`115`	`115`	`}`
`116`	`116`
`117`	`117`	`from`
`118`		`-CallToFunctionWithRestrictParameterscall,CallToFunctionWithRestrictParametersArgExprarg1,`
	`118`	`+PointerValueToRestrictArgConfigconfig,CallToFunctionWithRestrictParameterscall,`
	`119`	`+CallToFunctionWithRestrictParametersArgExprarg1,`
`119`	`120`	`CallToFunctionWithRestrictParametersArgExprarg2,intargOffset1,intargOffset2,Exprsource1,`
`120`	`121`	`Exprsource2,stringsourceMessage1,stringsourceMessage2`
`121`	`122`	`where`
`@@ -124,8 +125,8 @@ where`
`124`	`125`	`arg2=call.getAPtrArg(_)and`
`125`	`126`	`// enforce ordering to remove permutations if multiple restrict-qualified args exist`
`126`	`127`	`(notarg2=call.getARestrictPtrArg()orarg2.getParamIndex()>arg1.getParamIndex())and`
`127`		`-// check if two pointers address the same object`
`128`		`-exists(PointerValueToRestrictArgConfigconfig\|`
	`128`	`+(`
	`129`	`+// check if two pointers address the same object`
`129`	`130`	`config.hasFlow(DataFlow::exprNode(source1), DataFlow::exprNode(arg1.getAChild*()))and`
`130`	`131`	`(`
`131`	`132`	`// one pointer value flows to both args`

Lines changed: 0 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -51,10 +51,6 @@ class AssignedValueToRestrictPtrValueConfiguration extends DataFlow::Configurati`
`51`	`51`	`overridepredicateisSink(DataFlow::Nodesink){`
`52`	`52`	`sink.asExpr()instanceofAssignmentOrInitializationToRestrictPtrValueExpr`
`53`	`53`	`}`
`54`		`-`
`55`		`-overridepredicateisBarrierIn(DataFlow::Nodenode){`
`56`		`-isSource(node)`
`57`		`-}`
`58`	`54`	`}`
`59`	`55`
`60`	`56`	`from`

Comments

(0)