Commit25e29e4

committed

RefineTLoopCounterMutatedInLoopBody

This refined definition can handle more cases than the previous onethat only looked into the loop body, and better matches the descriptionin the comment above.

1 parentd37bc70 commit25e29e4Copy full SHA for 25e29e4

File tree

1 file changed

-2

lines changed

cpp/misra/src/rules/RULE-9-5-1
- LegacyForStatementsShouldBeSimple.ql

1 file changed

-2

lines changed

`‎cpp/misra/src/rules/RULE-9-5-1/LegacyForStatementsShouldBeSimple.ql‎`

Lines changed: 3 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -170,8 +170,9 @@ private newtype TAlertType =`
`170`	`170`	`/* 3-1. The loop counter is mutated somewhere other than its update expression. */`
`171`	`171`	`TLoopCounterMutatedInLoopBody(ForStmtforLoop,VariableloopCounterVariable){`
`172`	`172`	`loopCounterVariable=getDeclaredVariableInForLoop(forLoop)and`
`173`		`-variableModifiedInExpression(forLoop.getStmt().getChildStmt().getAChild*(),`
`174`		`-loopCounterVariable.getAnAccess())`
	`173`	`+exists(ExprmutatingExpr\|notmutatingExpr=forLoop.getUpdate().getAChild*()\|`
	`174`	`+variableModifiedInExpression(mutatingExpr,loopCounterVariable.getAnAccess())`
	`175`	`+)`
`175`	`176`	`}or`
`176`	`177`	/* 3-2. The loop counter is not updated using either of `++`, `--`, `+=`, or `-=`. */
`177`	`178`	`TLoopCounterUpdatedNotByCrementOrAddSubAssignmentExpr(`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit25e29e4

File tree

1 file changed

1 file changed

`‎cpp/misra/src/rules/RULE-9-5-1/LegacyForStatementsShouldBeSimple.ql‎`

0 commit comments